Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: src/debug/debug.h

Issue 1453113002: Handle StepIn for constructors through PrepareStep just like for regular calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add ports Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler.cc ('k') | src/debug/debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.h
diff --git a/src/debug/debug.h b/src/debug/debug.h
index a7922c3ad2a6676cc3d6f969b8e9c0513af160d3..59421100ce32f73c4f0768d6b4cbc95ec29c50bd 100644
--- a/src/debug/debug.h
+++ b/src/debug/debug.h
@@ -90,7 +90,7 @@ class BreakLocation {
return RelocInfo::IsDebugBreakSlotAtConstructCall(rmode_);
}
inline int CallArgumentsCount() const {
- DCHECK(IsCall());
+ DCHECK(IsStepInLocation());
return RelocInfo::DebugBreakCallArgumentsCount(data_);
}
@@ -411,7 +411,7 @@ class Debug {
bool IsStepping() { return thread_local_.step_count_ > 0; }
bool StepNextContinue(BreakLocation* location, JavaScriptFrame* frame);
bool StepInActive() { return thread_local_.step_into_fp_ != 0; }
- void HandleStepIn(Handle<Object> function_obj, bool is_constructor);
+ void HandleStepIn(Handle<Object> function_obj);
bool StepOutActive() { return thread_local_.step_out_fp_ != 0; }
void GetStepinPositions(JavaScriptFrame* frame, StackFrame::Id frame_id,
« no previous file with comments | « src/assembler.cc ('k') | src/debug/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698