Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 1453113002: Handle StepIn for constructors through PrepareStep just like for regular calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add ports Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-classes.cc ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/debug/debug-evaluate.h" 9 #include "src/debug/debug-evaluate.h"
10 #include "src/debug/debug-frames.h" 10 #include "src/debug/debug-frames.h"
(...skipping 1719 matching lines...) Expand 10 before | Expand all | Expand 10 after
1730 return Smi::FromInt(isolate->debug()->is_active()); 1730 return Smi::FromInt(isolate->debug()->is_active());
1731 } 1731 }
1732 1732
1733 1733
1734 RUNTIME_FUNCTION(Runtime_DebugHandleStepIntoAccessor) { 1734 RUNTIME_FUNCTION(Runtime_DebugHandleStepIntoAccessor) {
1735 HandleScope scope(isolate); 1735 HandleScope scope(isolate);
1736 DCHECK(args.length() == 2); 1736 DCHECK(args.length() == 2);
1737 CONVERT_ARG_HANDLE_CHECKED(JSFunction, function, 0); 1737 CONVERT_ARG_HANDLE_CHECKED(JSFunction, function, 0);
1738 Debug* debug = isolate->debug(); 1738 Debug* debug = isolate->debug();
1739 // Handle stepping into constructors if step into is active. 1739 // Handle stepping into constructors if step into is active.
1740 if (debug->StepInActive()) debug->HandleStepIn(function, false); 1740 if (debug->StepInActive()) debug->HandleStepIn(function);
1741 return *isolate->factory()->undefined_value(); 1741 return *isolate->factory()->undefined_value();
1742 } 1742 }
1743 1743
1744 1744
1745 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 1745 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
1746 UNIMPLEMENTED(); 1746 UNIMPLEMENTED();
1747 return NULL; 1747 return NULL;
1748 } 1748 }
1749 } // namespace internal 1749 } // namespace internal
1750 } // namespace v8 1750 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime-classes.cc ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698