Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: src/full-codegen/full-codegen.cc

Issue 1453113002: Handle StepIn for constructors through PrepareStep just like for regular calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add ports Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/full-codegen/full-codegen.h" 5 #include "src/full-codegen/full-codegen.h"
6 6
7 #include "src/ast.h" 7 #include "src/ast.h"
8 #include "src/ast-numbering.h" 8 #include "src/ast-numbering.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 594 matching lines...) Expand 10 before | Expand all | Expand 10 after
605 if (expr->position() == RelocInfo::kNoPosition) return; 605 if (expr->position() == RelocInfo::kNoPosition) return;
606 RecordPosition(masm_, expr->position()); 606 RecordPosition(masm_, expr->position());
607 if (info_->is_debug()) { 607 if (info_->is_debug()) {
608 // Always emit a debug break slot before a call. 608 // Always emit a debug break slot before a call.
609 DebugCodegen::GenerateSlot(masm_, RelocInfo::DEBUG_BREAK_SLOT_AT_CALL, 609 DebugCodegen::GenerateSlot(masm_, RelocInfo::DEBUG_BREAK_SLOT_AT_CALL,
610 argc); 610 argc);
611 } 611 }
612 } 612 }
613 613
614 614
615 void FullCodeGenerator::SetConstructCallPosition(Expression* expr) { 615 void FullCodeGenerator::SetConstructCallPosition(Expression* expr, int argc) {
616 if (expr->position() == RelocInfo::kNoPosition) return; 616 if (expr->position() == RelocInfo::kNoPosition) return;
617 RecordPosition(masm_, expr->position()); 617 RecordPosition(masm_, expr->position());
618 if (info_->is_debug()) { 618 if (info_->is_debug()) {
619 // Always emit a debug break slot before a construct call. 619 // Always emit a debug break slot before a construct call.
620 DebugCodegen::GenerateSlot(masm_, 620 DebugCodegen::GenerateSlot(
621 RelocInfo::DEBUG_BREAK_SLOT_AT_CONSTRUCT_CALL); 621 masm_, RelocInfo::DEBUG_BREAK_SLOT_AT_CONSTRUCT_CALL, argc);
622 } 622 }
623 } 623 }
624 624
625 625
626 void FullCodeGenerator::VisitSuperPropertyReference( 626 void FullCodeGenerator::VisitSuperPropertyReference(
627 SuperPropertyReference* super) { 627 SuperPropertyReference* super) {
628 __ CallRuntime(Runtime::kThrowUnsupportedSuperError, 0); 628 __ CallRuntime(Runtime::kThrowUnsupportedSuperError, 0);
629 } 629 }
630 630
631 631
(...skipping 1104 matching lines...) Expand 10 before | Expand all | Expand 10 after
1736 return var->mode() == CONST_LEGACY || var->scope()->is_nonlinear() || 1736 return var->mode() == CONST_LEGACY || var->scope()->is_nonlinear() ||
1737 var->initializer_position() >= proxy->position(); 1737 var->initializer_position() >= proxy->position();
1738 } 1738 }
1739 1739
1740 1740
1741 #undef __ 1741 #undef __
1742 1742
1743 1743
1744 } // namespace internal 1744 } // namespace internal
1745 } // namespace v8 1745 } // namespace v8
OLDNEW
« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698