Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 145073003: Indicate which authentication flow was used in UserContext (Closed)

Created:
6 years, 11 months ago by bartfab (slow)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Indicate which authentication flow was used in UserContext This CL adds a field to UserContext that indicates which authentication flow was used (online without SAML, online with SAML, offline). This distinction will be used to implement a policy that forces SAML users to log in via the online authentication flow periodically. BUG=332081 TEST=Manual (automated tests coming in follow-up CL that adds the policy) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246674 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246896

Patch Set 1 #

Patch Set 2 : Speculative fix for telemetry. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -49 lines) Patch
M chrome/browser/chromeos/login/login_performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 2 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user.h View 6 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/user.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 chunk +11 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_common.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/gaia_auth/main.js View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/gaia_auth_host.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bartfab (slow)
Hi Nikita, Could you please review? FYI: This is the first CL of a three-CL ...
6 years, 11 months ago (2014-01-22 17:34:56 UTC) #1
Nikita (slow)
lgtm
6 years, 11 months ago (2014-01-23 16:27:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/145073003/1
6 years, 11 months ago (2014-01-23 17:42:27 UTC) #3
commit-bot: I haz the power
Change committed as 246674
6 years, 11 months ago (2014-01-23 20:23:55 UTC) #4
achuithb
On 2014/01/23 20:23:55, I haz the power (commit-bot) wrote: > Change committed as 246674 I ...
6 years, 11 months ago (2014-01-23 22:32:49 UTC) #5
achuithb
Reverted: https://codereview.chromium.org/137133007/ Please get a green run on cros_x86, cros_arm and/or cros_daisy before relanding. You ...
6 years, 11 months ago (2014-01-23 23:07:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/145073003/290001
6 years, 11 months ago (2014-01-24 11:59:28 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 15:29:19 UTC) #8
Message was sent while issue was closed.
Change committed as 246896

Powered by Google App Engine
This is Rietveld 408576698