Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/resources/gaia_auth/main.js

Issue 145073003: Indicate which authentication flow was used in UserContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Speculative fix for telemetry. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/gaia_auth/main.js
diff --git a/chrome/browser/resources/gaia_auth/main.js b/chrome/browser/resources/gaia_auth/main.js
index 936ea1d13f8daaf301efae5bd0cf9abb40b5f463..f2c7f36e2f25af0ed4088877c9e5cb702090169a 100644
--- a/chrome/browser/resources/gaia_auth/main.js
+++ b/chrome/browser/resources/gaia_auth/main.js
@@ -182,11 +182,12 @@ Authenticator.prototype = {
}
},
- completeLogin: function(username, password) {
+ completeLogin: function() {
var msg = {
'method': 'completeLogin',
- 'email': username,
- 'password': password
+ 'email': this.email_,
+ 'password': this.password_,
+ 'usingSAML': this.isSAMLFlow_
};
window.parent.postMessage(msg, this.parentPage_);
if (this.samlSupportChannel_)
@@ -277,7 +278,7 @@ Authenticator.prototype = {
onConfirmLogin_: function() {
if (!this.isSAMLFlow_) {
- this.completeLogin(this.email_, this.password_);
+ this.completeLogin();
return;
}
@@ -307,7 +308,7 @@ Authenticator.prototype = {
// SAML login is complete when the user's e-mail address has been retrieved
// from GAIA and the user has successfully confirmed the password.
if (this.email_ !== null && this.password_ !== null)
- this.completeLogin(this.email_, this.password_);
+ this.completeLogin();
},
onVerifyConfirmedPassword_: function(password) {

Powered by Google App Engine
This is Rietveld 408576698