Add local state flag to force online login for a user

Add local state flag to force online login for a user

This CL adds a flag in local stat that forces a user to go through the
online login flow.  This flag will be used to implement a policy that
forces SAML users to log in via the online authentication flow
periodically.

BUG=332081
TEST=Manual (automated tests coming in follow-up CL that adds the policy)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247152

[bartfab (slow), 2014-01-22 17:35:23]

Hi Nikita,

Could you please review?

FYI: This is the second CL of a three-CL set:

https://codereview.chromium.org/145073003/
https://codereview.chromium.org/143873012/
https://codereview.chromium.org/143463009/

[Nikita (slow), 2014-01-23 16:06:56]

lgtm

https://codereview.chromium.org/143873012/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/user.h (right):

https://codereview.chromium.org/143873012/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/user.h:174: bool force_online_signin() const {
return force_online_signin_; }
nit: Please add comment.

https://codereview.chromium.org/143873012/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/user_manager_impl.cc (right):

https://codereview.chromium.org/143873012/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/user_manager_impl.cc:100: const char
kUserForceOnlineSignin[] = "UserForceOnlineSiginin";
nit: UserForceOnlineSignin

https://codereview.chromium.org/143873012/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/user_manager_impl.h (right):

https://codereview.chromium.org/143873012/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/user_manager_impl.h:254: bool
LoadForceOnlineSignin(const std::string& user_id) const;
nit: Please add comment.

[bartfab (slow), 2014-01-24 12:08:04]

https://codereview.chromium.org/143873012/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/user.h (right):

https://codereview.chromium.org/143873012/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/user.h:174: bool force_online_signin() const {
return force_online_signin_; }
On 2014/01/23 16:06:56, Nikita Kostylev wrote:
> nit: Please add comment.

Done.

https://codereview.chromium.org/143873012/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/user_manager_impl.cc (right):

https://codereview.chromium.org/143873012/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/user_manager_impl.cc:100: const char
kUserForceOnlineSignin[] = "UserForceOnlineSiginin";
On 2014/01/23 16:06:56, Nikita Kostylev wrote:
> nit: UserForceOnlineSignin

Done.

https://codereview.chromium.org/143873012/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/user_manager_impl.h (right):

https://codereview.chromium.org/143873012/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/user_manager_impl.h:254: bool
LoadForceOnlineSignin(const std::string& user_id) const;
On 2014/01/23 16:06:56, Nikita Kostylev wrote:
> nit: Please add comment.

Done.

[commit-bot: I haz the power, 2014-01-24 23:00:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/143873012/90001

[commit-bot: I haz the power, 2014-01-25 00:38:26]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2014-01-25 12:42:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/143873012/460001

[commit-bot: I haz the power, 2014-01-25 14:43:21]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-25 17:20:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/143873012/460001

[commit-bot: I haz the power, 2014-01-25 22:52:49]

Change committed as 247152