Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3632)

Unified Diff: chrome/browser/chromeos/login/parallel_authenticator_unittest.cc

Issue 145073003: Indicate which authentication flow was used in UserContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Speculative fix for telemetry. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/parallel_authenticator_unittest.cc
diff --git a/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc b/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc
index 08f02bd362e1ed4b93afceaa38064ef246671a63..27a82202212b614eb3dbe3c0843616f84b5b8951 100644
--- a/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc
+++ b/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc
@@ -146,11 +146,13 @@ class ParallelAuthenticatorTest : public testing::Test {
const std::string& password,
const std::string& username_hash_,
bool pending) {
- EXPECT_CALL(consumer_, OnLoginSuccess(UserContext(username,
- password,
- std::string(),
- username_hash_,
- true /* using_oauth */)))
+ EXPECT_CALL(consumer_, OnLoginSuccess(UserContext(
+ username,
+ password,
+ std::string(),
+ username_hash_,
+ true, // using_oauth
+ UserContext::AUTH_FLOW_OFFLINE)))
.WillOnce(Invoke(MockConsumer::OnSuccessQuit))
.RetiresOnSaturation();
}
@@ -207,11 +209,13 @@ class ParallelAuthenticatorTest : public testing::Test {
};
TEST_F(ParallelAuthenticatorTest, OnLoginSuccess) {
- EXPECT_CALL(consumer_, OnLoginSuccess(UserContext(username_,
- password_,
- std::string(),
- username_hash_,
- true /* using oauth */)))
+ EXPECT_CALL(consumer_, OnLoginSuccess(UserContext(
+ username_,
+ password_,
+ std::string(),
+ username_hash_,
+ true, // using oauth
+ UserContext::AUTH_FLOW_OFFLINE)))
.Times(1)
.RetiresOnSaturation();
« no previous file with comments | « chrome/browser/chromeos/login/parallel_authenticator.cc ('k') | chrome/browser/chromeos/login/screen_locker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698