Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 137133007: Revert 246674 "Indicate which authentication flow was used in Us..." (Closed)

Created:
6 years, 11 months ago by achuithb
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 246674 "Indicate which authentication flow was used in Us..." This CL breaks telemetry login. Reverting. > Indicate which authentication flow was used in UserContext > > This CL adds a field to UserContext that indicates which authentication > flow was used (online without SAML, online with SAML, offline). This > distinction will be used to implement a policy that forces SAML users to > log in via the online authentication flow periodically. > > BUG=332081 > TEST=Manual (automated tests coming in follow-up CL that adds the policy) > > Review URL: https://codereview.chromium.org/145073003 TBR=bartfab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -93 lines) Patch
M trunk/src/chrome/browser/chromeos/login/login_performer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/parallel_authenticator.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 2 chunks +10 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/screen_locker.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/user.h View 6 chunks +8 lines, -20 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/user.cc View 4 chunks +6 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/user_manager_impl.cc View 1 chunk +9 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/chrome/browser/resources/gaia_auth/main.js View 3 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/resources/gaia_auth_host/gaia_auth_host.js View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +4 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
achuithb
6 years, 11 months ago (2014-01-23 23:01:56 UTC) #1
achuithb
Committed patchset #1 manually as r246712.
6 years, 11 months ago (2014-01-23 23:02:12 UTC) #2
achuithb
Dan: Sorry, should've probably talked to you first. This CL breaks telemetry, and hence the ...
6 years, 11 months ago (2014-01-23 23:04:52 UTC) #3
Daniel Erat
No problem. I was just staring at these failure -- thanks for reverting it!
6 years, 11 months ago (2014-01-23 23:06:35 UTC) #4
Daniel Erat
6 years, 11 months ago (2014-01-23 23:06:44 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698