Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 1447563002: Implement frame attribution (FrameBlamer) (Closed)

Created:
5 years, 1 month ago by Sami
Modified:
4 years, 8 months ago
CC:
chiniforooshan, chromium-reviews, fmeawad, kouhei (in TOK), nduca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement frame attribution (FrameBlamer) This patch implements two types of blame contexts: 1. A render frame blame context, which is used to attribute costs toward a particular web frame (i.e., a top-level frame or an iframe). 2. A render thread blame context, which is the target for accounting costs that do not neatly fit into a single web frame. Examples of this are garbage collection and "default" task queues which span the entire renderer. Design doc: https://docs.google.com/document/d/15BB-suCb9j-nFt55yCFJBJCGzLg2qUm3WaSOPb8APtI BUG=546021 Committed: https://crrev.com/b4cce1b31ea37766c159762f1b45af7599f72d62 Cr-Commit-Position: refs/heads/master@{#384323}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : Cleanup. #

Patch Set 5 : Also record the context id when leaving. #

Patch Set 6 : Use idRef to refer to parents. #

Patch Set 7 : Fix frame tree hierarchy. #

Patch Set 8 : Dump frame tree when starting to trace. #

Patch Set 9 : Make sure newly created objects get traced. #

Patch Set 10 : Also include remote frames in the frame tree. #

Patch Set 11 : Count compositor tasks toward the isolate too. #

Patch Set 12 : v8/gc tracing. #

Patch Set 13 : Rebased. #

Patch Set 14 : Make category explicit. #

Patch Set 15 : Add names to contexts. #

Patch Set 16 : Rebased. #

Patch Set 17 : Reworked. #

Patch Set 18 : Added a missing file. #

Patch Set 19 : Rebased, snapshot render frames when tracing starts #

Patch Set 20 : Remove v8 isolate context. #

Patch Set 21 : Fix blink layering violations. #

Patch Set 22 : Experiment with tracing more things at the content layer. #

Patch Set 23 : Blame context WIP snapshot. #

Patch Set 24 : Blame context tests. #

Patch Set 25 : It builds => ship it. #

Total comments: 4

Patch Set 26 : Fix category crosstalk. #

Patch Set 27 : Trace event analyzer tests. #

Patch Set 28 : Cleanup. #

Total comments: 2

Patch Set 29 : Added URL snapshotting. #

Patch Set 30 : Split out https://codereview.chromium.org/1776673002/ #

Patch Set 31 : Remove old security origin plumbing. #

Patch Set 32 : Added scheduler test. #

Patch Set 33 : Rebased. #

Patch Set 34 : Rebased. #

Patch Set 35 : Rebased. #

Patch Set 36 : Rebased. #

Patch Set 37 : Rebased. #

Patch Set 38 : Rebased. #

Patch Set 39 : Fix TQM test. #

Patch Set 40 : Cleanup. #

Total comments: 6

Patch Set 41 : Review comments. #

Total comments: 8

Patch Set 42 : Centralize logic. #

Patch Set 43 : Removed extra include. #

Patch Set 44 : Cleanup. #

Patch Set 45 : Fix layout test crash. #

Patch Set 46 : Rebased #

Total comments: 7

Patch Set 47 : Rebased. #

Patch Set 48 : Removed url property and improved naming. #

Patch Set 49 : Fix test failures #

Patch Set 50 : Make sure blame context is initialized early enough #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -64 lines) Patch
M components/scheduler/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/base/task_queue.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 2 chunks +13 lines, -0 lines 0 comments Download
D components/scheduler/base/task_queue.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +0 lines, -5 lines 0 comments Download
M components/scheduler/base/task_queue_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 2 chunks +2 lines, -0 lines 0 comments Download
M components/scheduler/base/task_queue_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 5 chunks +12 lines, -1 line 0 comments Download
M components/scheduler/base/task_queue_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 2 chunks +73 lines, -0 lines 0 comments Download
M components/scheduler/child/compositor_worker_scheduler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +4 lines, -0 lines 0 comments Download
M components/scheduler/child/single_thread_idle_task_runner.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 3 chunks +10 lines, -0 lines 0 comments Download
M components/scheduler/child/single_thread_idle_task_runner.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 3 chunks +11 lines, -0 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 2 chunks +12 lines, -0 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +2 lines, -0 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +16 lines, -0 lines 0 comments Download
M components/scheduler/renderer/web_frame_scheduler_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 4 chunks +7 lines, -4 lines 0 comments Download
M components/scheduler/renderer/web_frame_scheduler_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 5 chunks +13 lines, -10 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 3 chunks +7 lines, -3 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +6 lines, -4 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 5 chunks +9 lines, -8 lines 0 comments Download
M components/scheduler/scheduler.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 2 chunks +4 lines, -0 lines 0 comments Download
A content/renderer/frame_blame_context.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 1 chunk +26 lines, -0 lines 0 comments Download
A content/renderer/frame_blame_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 1 chunk +41 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 4 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 8 chunks +17 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 3 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 3 chunks +9 lines, -0 lines 0 comments Download
A content/renderer/top_level_blame_context.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +25 lines, -0 lines 0 comments Download
A content/renderer/top_level_blame_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +25 lines, -0 lines 0 comments Download
M content/test/fake_renderer_scheduler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/fake_renderer_scheduler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 3 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameClient.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/TraceEvent.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 1 chunk +7 lines, -0 lines 0 comments Download
A + third_party/WebKit/public/platform/BlameContext.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +5 lines, -9 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebFrameScheduler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebViewScheduler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 59 (22 generated)
Sami
FYI this needs some polish, but base::debug::BlameContext is what I had in mind for making ...
4 years, 9 months ago (2016-02-26 21:35:17 UTC) #2
benjhayden
On 2016/02/26 at 21:35:17, skyostil wrote: > FYI this needs some polish, but base::debug::BlameContext is ...
4 years, 9 months ago (2016-02-29 18:51:25 UTC) #3
Sami
On 2016/02/29 18:51:25, benjhayden_chromium wrote: > I generally try very hard to avoid bike-shedding, but ...
4 years, 9 months ago (2016-02-29 19:28:59 UTC) #4
benjhayden
Still reviewing but it's lunch time. :-) This is looking pretty neat! Should my FrameTreeNode ...
4 years, 9 months ago (2016-02-29 19:30:37 UTC) #6
Sami
Thanks for digging into this -- sorry I haven't written any comments for the interface ...
4 years, 9 months ago (2016-02-29 20:20:31 UTC) #7
Sami
+fady too.
4 years, 9 months ago (2016-02-29 20:21:06 UTC) #8
Fady Samuel
I think you got the wrong Fad(y|i). +fmeawad@. +nduca@ in CC for giggles. :P
4 years, 9 months ago (2016-02-29 20:23:19 UTC) #10
Sami
Sorry, autocomplete fail on my part :\
4 years, 9 months ago (2016-02-29 20:27:14 UTC) #12
Sami
+kouhei@
4 years, 9 months ago (2016-02-29 23:55:01 UTC) #13
chiniforooshan
https://codereview.chromium.org/1447563002/diff/540001/components/scheduler/base/task_queue.h File components/scheduler/base/task_queue.h (right): https://codereview.chromium.org/1447563002/diff/540001/components/scheduler/base/task_queue.h#newcode194 components/scheduler/base/task_queue.h:194: // Set the blame context for all tasks executed ...
4 years, 9 months ago (2016-03-03 20:39:41 UTC) #16
Sami
https://codereview.chromium.org/1447563002/diff/540001/components/scheduler/base/task_queue.h File components/scheduler/base/task_queue.h (right): https://codereview.chromium.org/1447563002/diff/540001/components/scheduler/base/task_queue.h#newcode194 components/scheduler/base/task_queue.h:194: // Set the blame context for all tasks executed ...
4 years, 9 months ago (2016-03-08 14:36:10 UTC) #17
Sami
Okay, I think the base/ interface is now settling down. Ben, Ehsan, WDYT about this ...
4 years, 9 months ago (2016-03-21 12:25:19 UTC) #21
alex clarke (OOO till 29th)
scheduler/ LGTM https://codereview.chromium.org/1447563002/diff/800001/components/scheduler/base/task_queue.h File components/scheduler/base/task_queue.h (right): https://codereview.chromium.org/1447563002/diff/800001/components/scheduler/base/task_queue.h#newcode195 components/scheduler/base/task_queue.h:195: // this task queue. |blame_context| must be ...
4 years, 9 months ago (2016-03-21 14:38:36 UTC) #22
Sami
Thanks Alex, all addressed. https://codereview.chromium.org/1447563002/diff/800001/components/scheduler/base/task_queue.h File components/scheduler/base/task_queue.h (right): https://codereview.chromium.org/1447563002/diff/800001/components/scheduler/base/task_queue.h#newcode195 components/scheduler/base/task_queue.h:195: // this task queue. |blame_context| ...
4 years, 9 months ago (2016-03-21 15:18:05 UTC) #23
benjhayden
https://codereview.chromium.org/1447563002/diff/820001/components/scheduler/base/time_domain.cc File components/scheduler/base/time_domain.cc (right): https://codereview.chromium.org/1447563002/diff/820001/components/scheduler/base/time_domain.cc#newcode231 components/scheduler/base/time_domain.cc:231: state->EndArray(); Looks like a bugfix for a separate CL? ...
4 years, 9 months ago (2016-03-21 17:32:57 UTC) #24
Sami
https://codereview.chromium.org/1447563002/diff/820001/components/scheduler/base/time_domain.cc File components/scheduler/base/time_domain.cc (right): https://codereview.chromium.org/1447563002/diff/820001/components/scheduler/base/time_domain.cc#newcode231 components/scheduler/base/time_domain.cc:231: state->EndArray(); On 2016/03/21 17:32:56, benjhayden_chromium wrote: > Looks like ...
4 years, 9 months ago (2016-03-21 19:16:30 UTC) #25
benjhayden
lgtm, thanks!
4 years, 9 months ago (2016-03-21 19:31:38 UTC) #26
Sami
Thanks Ben. Jochen, mind taking a look at content/ and third_party/WebKit?
4 years, 9 months ago (2016-03-22 10:30:13 UTC) #28
Sami
Rebased
4 years, 9 months ago (2016-03-23 12:37:53 UTC) #29
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1447563002/diff/910001/third_party/WebKit/public/platform/BlameContext.h File third_party/WebKit/public/platform/BlameContext.h (right): https://codereview.chromium.org/1447563002/diff/910001/third_party/WebKit/public/platform/BlameContext.h#newcode12 third_party/WebKit/public/platform/BlameContext.h:12: using BlameContext = base::trace_event::BlameContext; why not just use this ...
4 years, 9 months ago (2016-03-24 14:38:39 UTC) #30
jochen (gone - plz use gerrit)
+esprehn for realz. See my previous comment for the question
4 years, 9 months ago (2016-03-24 14:38:59 UTC) #32
esprehn
RenderFrameBlameContext should be a blink API instead. https://codereview.chromium.org/1447563002/diff/910001/content/renderer/render_frame_blame_context.cc File content/renderer/render_frame_blame_context.cc (right): https://codereview.chromium.org/1447563002/diff/910001/content/renderer/render_frame_blame_context.cc#newcode45 content/renderer/render_frame_blame_context.cc:45: url_ = ...
4 years, 9 months ago (2016-03-25 03:33:22 UTC) #33
Sami
Thanks for the comments Elliott. > RenderFrameBlameContext should be a blink API instead. That was ...
4 years, 8 months ago (2016-03-29 10:37:36 UTC) #34
Sami
Elliott and I had a chat and concluded that having the blame context in content/ ...
4 years, 8 months ago (2016-03-30 13:44:32 UTC) #35
esprehn
lgtm https://codereview.chromium.org/1447563002/diff/910001/third_party/WebKit/public/platform/Platform.h File third_party/WebKit/public/platform/Platform.h (right): https://codereview.chromium.org/1447563002/diff/910001/third_party/WebKit/public/platform/Platform.h#newcode363 third_party/WebKit/public/platform/Platform.h:363: virtual BlameContext* threadBlameContext() { return nullptr; } can ...
4 years, 8 months ago (2016-03-31 00:47:04 UTC) #36
Sami
Fix test failures
4 years, 8 months ago (2016-03-31 10:28:40 UTC) #37
Sami
Thanks! https://codereview.chromium.org/1447563002/diff/910001/third_party/WebKit/public/platform/Platform.h File third_party/WebKit/public/platform/Platform.h (right): https://codereview.chromium.org/1447563002/diff/910001/third_party/WebKit/public/platform/Platform.h#newcode363 third_party/WebKit/public/platform/Platform.h:363: virtual BlameContext* threadBlameContext() { return nullptr; } On ...
4 years, 8 months ago (2016-03-31 10:29:49 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447563002/970001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447563002/970001
4 years, 8 months ago (2016-03-31 10:30:16 UTC) #41
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/196912)
4 years, 8 months ago (2016-03-31 10:32:54 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447563002/970001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447563002/970001
4 years, 8 months ago (2016-03-31 10:59:06 UTC) #45
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/189925)
4 years, 8 months ago (2016-03-31 11:28:54 UTC) #47
Sami
Make sure blame context is initialized early enough
4 years, 8 months ago (2016-03-31 15:13:19 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447563002/990001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447563002/990001
4 years, 8 months ago (2016-03-31 15:17:30 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/167014)
4 years, 8 months ago (2016-03-31 15:59:52 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447563002/990001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447563002/990001
4 years, 8 months ago (2016-03-31 17:06:04 UTC) #55
commit-bot: I haz the power
Committed patchset #50 (id:990001)
4 years, 8 months ago (2016-03-31 17:56:50 UTC) #57
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 17:59:47 UTC) #59
Message was sent while issue was closed.
Patchset 50 (id:??) landed as
https://crrev.com/b4cce1b31ea37766c159762f1b45af7599f72d62
Cr-Commit-Position: refs/heads/master@{#384323}

Powered by Google App Engine
This is Rietveld 408576698