third_party/WebKit/Source/core/page/ChromeClient.h - Issue 1447563002: Implement frame attribution (FrameBlamer)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.h

Issue 1447563002: Implement frame attribution (FrameBlamer) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make sure blame context is initialized early enough Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/ChromeClient.h

diff --git a/third_party/WebKit/Source/core/page/ChromeClient.h b/third_party/WebKit/Source/core/page/ChromeClient.h

index 71bd365494b3cb0a48246c6a64e6ddd2bfed99ba..23ac7a6d635970c6f3554f229c95bc9b19164e87 100644

--- a/third_party/WebKit/Source/core/page/ChromeClient.h

+++ b/third_party/WebKit/Source/core/page/ChromeClient.h

@@ -35,6 +35,7 @@

#include "platform/PopupMenu.h"

#include "platform/heap/Handle.h"

#include "platform/scroll/ScrollTypes.h"

+#include "public/platform/BlameContext.h"

#include "public/platform/WebEventListenerProperties.h"

#include "public/platform/WebFocusType.h"

#include "wtf/Forward.h"

@@ -258,7 +259,7 @@ public:

// that this is comprehensive.

virtual void didObserveNonGetFetchFromScript() const {}

- virtual PassOwnPtr<WebFrameScheduler> createFrameScheduler() = 0;

+ virtual PassOwnPtr<WebFrameScheduler> createFrameScheduler(BlameContext*) = 0;

protected:

~ChromeClient() override { }