Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: content/renderer/render_frame_impl.h

Issue 1447563002: Implement frame attribution (FrameBlamer) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make sure blame context is initialized early enough Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/frame_blame_context.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 729c9498d44e9369d194f3a64381af62cc0052e7..a852cadf37cbbdafabfbe3b1215aaa57a1118c2b 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -29,6 +29,7 @@
#include "content/public/common/referrer.h"
#include "content/public/common/stop_find_action.h"
#include "content/public/renderer/render_frame.h"
+#include "content/renderer/frame_blame_context.h"
#include "content/renderer/render_frame_proxy.h"
#include "content/renderer/renderer_webcookiejar_impl.h"
#include "ipc/ipc_message.h"
@@ -429,6 +430,7 @@ class CONTENT_EXPORT RenderFrameImpl
const blink::WebPopupMenuInfo& popup_menu_info,
blink::WebExternalPopupMenuClient* popup_menu_client) override;
blink::WebCookieJar* cookieJar() override;
+ blink::BlameContext* frameBlameContext() override;
blink::WebServiceWorkerProvider* createServiceWorkerProvider() override;
void didAccessInitialDocument() override;
blink::WebFrame* createChildFrame(
@@ -979,6 +981,8 @@ class CONTENT_EXPORT RenderFrameImpl
const blink::WebRect& selection_rect,
bool final_status_update);
+ void InitializeBlameContext(RenderFrameImpl* parent_frame);
+
// Stores the WebLocalFrame we are associated with. This is null from the
// constructor until BindToWebFrame is called, and it is null after
// frameDetached is called until destruction (which is asynchronous in the
@@ -1203,6 +1207,8 @@ class CONTENT_EXPORT RenderFrameImpl
scoped_ptr<ExternalPopupMenu> external_popup_menu_;
#endif
+ FrameBlameContext* blame_context_; // Not owned.
+
base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
« no previous file with comments | « content/renderer/frame_blame_context.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698