third_party/WebKit/Source/core/frame/FrameClient.h - Issue 1447563002: Implement frame attribution (FrameBlamer)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameClient.h

Issue 1447563002: Implement frame attribution (FrameBlamer) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make sure blame context is initialized early enough Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameClient.h

diff --git a/third_party/WebKit/Source/core/frame/FrameClient.h b/third_party/WebKit/Source/core/frame/FrameClient.h

index cd8be7cf6b5a935d134c5bfa7ced25c584fc3eba..9f1fa98a28ca363ca9f05b3005c3717c96cad449 100644

--- a/third_party/WebKit/Source/core/frame/FrameClient.h

+++ b/third_party/WebKit/Source/core/frame/FrameClient.h

@@ -7,6 +7,7 @@

#include "core/CoreExport.h"

#include "platform/heap/Handle.h"

+#include "public/platform/BlameContext.h"

namespace blink {

@@ -43,6 +44,8 @@ public:

virtual void frameFocused() const = 0;

+ virtual BlameContext* frameBlameContext() { return nullptr; }

virtual ~FrameClient() { }

DEFINE_INLINE_VIRTUAL_TRACE() { }