third_party/WebKit/public/platform/BlameContext.h - Issue 1447563002: Implement frame attribution (FrameBlamer)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/BlameContext.h

Issue 1447563002: Implement frame attribution (FrameBlamer) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/render_frame_blame_context.cc ('K') | « third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp ('k') | third_party/WebKit/public/platform/Platform.h » ('j') | third_party/WebKit/public/platform/Platform.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef URLConversion_h	5 #ifndef BlameContext_h

6 #define URLConversion_h	6 #define BlameContext_h

7	7

8 #include "WebCommon.h"	8 #include "base/trace_event/blame_context.h"

9

10 class GURL;

11	9

12 namespace blink {	10 namespace blink {

13	11

14 class WebString;	12 using BlameContext = base::trace_event::BlameContext;
	jochen (gone - plz use gerrit) 2016/03/24 14:38:39 why not just use this directly? adding esprehn@ fo why not just use this directly? adding esprehn@ for input esprehn 2016/03/25 03:33:22 base is not allowed in core/, it's a simple rule t Show quoted text On 2016/03/24 at 14:38:39, jochen - slow wrote: > why not just use this directly? adding esprehn@ for input base is not allowed in core/, it's a simple rule to enforce what's being used where. Is the whole BlameContext API really for public use anywhere in blink? Sami 2016/03/29 10:37:36 It's ready, although I wouldn't expect that many c Show quoted text On 2016/03/25 03:33:22, esprehn wrote: > On 2016/03/24 at 14:38:39, jochen - slow wrote: > > why not just use this directly? adding esprehn@ for input > > base is not allowed in core/, it's a simple rule to enforce what's being used > where. Is the whole BlameContext API really for public use anywhere in blink? It's ready, although I wouldn't expect that many client using it. The main ones are in core/ where we want to annotate places where we descend into to different frames (e.g., during rAF) or do global things (GC).
15

16 BLINK_COMMON_EXPORT GURL WebStringToGURL(const WebString&);

17	13

18 } // namespace blink	14 } // namespace blink

19	15

20 #endif	16 #endif // BlameContext_h

OLD	NEW