Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1446973002: Oilpan: tidy up InspectorState weak references. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: tidy up InspectorState weak references. R=haraken BUG=553613 Committed: https://crrev.com/0f49104ae645ed2469da4ed5f79991b6463f8150 Cr-Commit-Position: refs/heads/master@{#359842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
5 years, 1 month ago (2015-11-16 13:05:34 UTC) #2
haraken
These classes are in core/inspector/v8/, which means that the inspector guys won't want to move ...
5 years, 1 month ago (2015-11-16 14:09:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1446973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1446973002/1
5 years, 1 month ago (2015-11-16 14:29:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 15:43:23 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 15:44:08 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0f49104ae645ed2469da4ed5f79991b6463f8150
Cr-Commit-Position: refs/heads/master@{#359842}

Powered by Google App Engine
This is Rietveld 408576698