Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

Issue 1446973002: Oilpan: tidy up InspectorState weak references. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8DebuggerAgentImpl_h 5 #ifndef V8DebuggerAgentImpl_h
6 #define V8DebuggerAgentImpl_h 6 #define V8DebuggerAgentImpl_h
7 7
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/ScriptValue.h" 9 #include "bindings/core/v8/ScriptValue.h"
10 #include "core/CoreExport.h" 10 #include "core/CoreExport.h"
11 #include "core/InspectorFrontend.h" 11 #include "core/InspectorFrontend.h"
12 #include "core/inspector/InspectorBaseAgent.h" 12 #include "core/inspector/InspectorBaseAgent.h"
13 #include "core/inspector/PromiseTracker.h" 13 #include "core/inspector/PromiseTracker.h"
14 #include "core/inspector/v8/ScriptBreakpoint.h" 14 #include "core/inspector/v8/ScriptBreakpoint.h"
15 #include "core/inspector/v8/V8DebuggerAgent.h" 15 #include "core/inspector/v8/V8DebuggerAgent.h"
16 #include "core/inspector/v8/V8DebuggerImpl.h" 16 #include "core/inspector/v8/V8DebuggerImpl.h"
17 #include "core/inspector/v8/V8DebuggerListener.h" 17 #include "core/inspector/v8/V8DebuggerListener.h"
18 #include "platform/heap/Handle.h"
18 #include "wtf/Forward.h" 19 #include "wtf/Forward.h"
19 #include "wtf/HashMap.h" 20 #include "wtf/HashMap.h"
20 #include "wtf/HashSet.h" 21 #include "wtf/HashSet.h"
21 #include "wtf/ListHashSet.h" 22 #include "wtf/ListHashSet.h"
22 #include "wtf/PassRefPtr.h" 23 #include "wtf/PassRefPtr.h"
23 #include "wtf/Vector.h" 24 #include "wtf/Vector.h"
24 #include "wtf/text/StringHash.h" 25 #include "wtf/text/StringHash.h"
25 26
26 namespace blink { 27 namespace blink {
27 28
(...skipping 16 matching lines...) Expand all
44 , public V8DebuggerListener 45 , public V8DebuggerListener
45 , public InspectorBackendDispatcher::DebuggerCommandHandler 46 , public InspectorBackendDispatcher::DebuggerCommandHandler
46 , public PromiseTracker::Listener { 47 , public PromiseTracker::Listener {
47 WTF_MAKE_NONCOPYABLE(V8DebuggerAgentImpl); 48 WTF_MAKE_NONCOPYABLE(V8DebuggerAgentImpl);
48 USING_FAST_MALLOC(V8DebuggerAgentImpl); 49 USING_FAST_MALLOC(V8DebuggerAgentImpl);
49 public: 50 public:
50 V8DebuggerAgentImpl(InjectedScriptManager*, V8DebuggerImpl*, int contextGrou pId); 51 V8DebuggerAgentImpl(InjectedScriptManager*, V8DebuggerImpl*, int contextGrou pId);
51 ~V8DebuggerAgentImpl() override; 52 ~V8DebuggerAgentImpl() override;
52 DECLARE_TRACE(); 53 DECLARE_TRACE();
53 54
54 void setInspectorState(InspectorState* state) override { m_state = state; } 55 void setInspectorState(InspectorState*) override;
55 void setFrontend(InspectorFrontend::Debugger* frontend) override { m_fronten d = frontend; } 56 void setFrontend(InspectorFrontend::Debugger* frontend) override { m_fronten d = frontend; }
56 void clearFrontend() override; 57 void clearFrontend() override;
57 void restore() override; 58 void restore() override;
58 void disable(ErrorString*) final; 59 void disable(ErrorString*) final;
59 60
60 bool isPaused() override; 61 bool isPaused() override;
61 62
62 // Part of the protocol. 63 // Part of the protocol.
63 void enable(ErrorString*) override; 64 void enable(ErrorString*) override;
64 void setBreakpointsActive(ErrorString*, bool active) final; 65 void setBreakpointsActive(ErrorString*, bool active) final;
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 NoStep = 0, 188 NoStep = 0,
188 StepInto, 189 StepInto,
189 StepOver, 190 StepOver,
190 StepOut 191 StepOut
191 }; 192 };
192 193
193 RawPtrWillBeWeakPersistent<InjectedScriptManager> m_injectedScriptManager; 194 RawPtrWillBeWeakPersistent<InjectedScriptManager> m_injectedScriptManager;
194 V8DebuggerImpl* m_debugger; 195 V8DebuggerImpl* m_debugger;
195 int m_contextGroupId; 196 int m_contextGroupId;
196 bool m_enabled; 197 bool m_enabled;
197 InspectorState* m_state; 198 RawPtrWillBeWeakPersistent<InspectorState> m_state;
198 InspectorFrontend::Debugger* m_frontend; 199 InspectorFrontend::Debugger* m_frontend;
199 v8::Isolate* m_isolate; 200 v8::Isolate* m_isolate;
200 RefPtr<ScriptState> m_pausedScriptState; 201 RefPtr<ScriptState> m_pausedScriptState;
201 v8::Global<v8::Object> m_currentCallStack; 202 v8::Global<v8::Object> m_currentCallStack;
202 ScriptsMap m_scripts; 203 ScriptsMap m_scripts;
203 BreakpointIdToDebuggerBreakpointIdsMap m_breakpointIdToDebuggerBreakpointIds ; 204 BreakpointIdToDebuggerBreakpointIdsMap m_breakpointIdToDebuggerBreakpointIds ;
204 DebugServerBreakpointToBreakpointIdAndSourceMap m_serverBreakpoints; 205 DebugServerBreakpointToBreakpointIdAndSourceMap m_serverBreakpoints;
205 String m_continueToLocationBreakpointId; 206 String m_continueToLocationBreakpointId;
206 InspectorFrontend::Debugger::Reason::Enum m_breakReason; 207 InspectorFrontend::Debugger::Reason::Enum m_breakReason;
207 RefPtr<JSONObject> m_breakAuxData; 208 RefPtr<JSONObject> m_breakAuxData;
(...skipping 27 matching lines...) Expand all
235 int m_currentAsyncOperationId; 236 int m_currentAsyncOperationId;
236 bool m_pendingTraceAsyncOperationCompleted; 237 bool m_pendingTraceAsyncOperationCompleted;
237 bool m_startingStepIntoAsync; 238 bool m_startingStepIntoAsync;
238 V8GlobalValueMap<String, v8::Script, v8::kNotWeak> m_compiledScripts; 239 V8GlobalValueMap<String, v8::Script, v8::kNotWeak> m_compiledScripts;
239 }; 240 };
240 241
241 } // namespace blink 242 } // namespace blink
242 243
243 244
244 #endif // V8DebuggerAgentImpl_h 245 #endif // V8DebuggerAgentImpl_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698