Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp

Issue 1446973002: Oilpan: tidy up InspectorState weak references. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/inspector/v8/V8DebuggerAgentImpl.h" 6 #include "core/inspector/v8/V8DebuggerAgentImpl.h"
7 7
8 #include "bindings/core/v8/ScriptCallStackFactory.h" 8 #include "bindings/core/v8/ScriptCallStackFactory.h"
9 #include "bindings/core/v8/ScriptRegexp.h" 9 #include "bindings/core/v8/ScriptRegexp.h"
10 #include "bindings/core/v8/ScriptValue.h" 10 #include "bindings/core/v8/ScriptValue.h"
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 { 258 {
259 if (depth <= 0) { 259 if (depth <= 0) {
260 m_maxAsyncCallStackDepth = 0; 260 m_maxAsyncCallStackDepth = 0;
261 resetAsyncCallTracker(); 261 resetAsyncCallTracker();
262 } else { 262 } else {
263 m_maxAsyncCallStackDepth = depth; 263 m_maxAsyncCallStackDepth = depth;
264 } 264 }
265 m_v8AsyncCallTracker->asyncCallTrackingStateChanged(m_maxAsyncCallStackDepth ); 265 m_v8AsyncCallTracker->asyncCallTrackingStateChanged(m_maxAsyncCallStackDepth );
266 } 266 }
267 267
268 void V8DebuggerAgentImpl::setInspectorState(InspectorState* state)
269 {
270 m_state = state;
271 }
272
268 void V8DebuggerAgentImpl::clearFrontend() 273 void V8DebuggerAgentImpl::clearFrontend()
269 { 274 {
270 ErrorString error; 275 ErrorString error;
271 disable(&error); 276 disable(&error);
272 ASSERT(m_frontend); 277 ASSERT(m_frontend);
273 m_frontend = nullptr; 278 m_frontend = nullptr;
274 } 279 }
275 280
276 void V8DebuggerAgentImpl::restore() 281 void V8DebuggerAgentImpl::restore()
277 { 282 {
(...skipping 1373 matching lines...) Expand 10 before | Expand all | Expand 10 after
1651 RefPtr<ExceptionDetails> exceptionDetails = ExceptionDetails::create().setTe xt(toCoreStringWithUndefinedOrNullCheck(message->Get())); 1656 RefPtr<ExceptionDetails> exceptionDetails = ExceptionDetails::create().setTe xt(toCoreStringWithUndefinedOrNullCheck(message->Get()));
1652 exceptionDetails->setLine(message->GetLineNumber()); 1657 exceptionDetails->setLine(message->GetLineNumber());
1653 exceptionDetails->setColumn(message->GetStartColumn()); 1658 exceptionDetails->setColumn(message->GetStartColumn());
1654 v8::Local<v8::StackTrace> messageStackTrace = message->GetStackTrace(); 1659 v8::Local<v8::StackTrace> messageStackTrace = message->GetStackTrace();
1655 if (!messageStackTrace.IsEmpty() && messageStackTrace->GetFrameCount() > 0) 1660 if (!messageStackTrace.IsEmpty() && messageStackTrace->GetFrameCount() > 0)
1656 exceptionDetails->setStackTrace(createScriptCallStack(isolate, messageSt ackTrace, messageStackTrace->GetFrameCount())->buildInspectorArray()); 1661 exceptionDetails->setStackTrace(createScriptCallStack(isolate, messageSt ackTrace, messageStackTrace->GetFrameCount())->buildInspectorArray());
1657 return exceptionDetails.release(); 1662 return exceptionDetails.release();
1658 } 1663 }
1659 1664
1660 } // namespace blink 1665 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698