Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

Issue 1446973002: Oilpan: tidy up InspectorState weak references. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h
diff --git a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h
index 30fd674fa602637b51e3d20e0b1031de32d98a3f..62a24e5bd7046037c8e4e817863722a18392ea77 100644
--- a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h
+++ b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h
@@ -15,6 +15,7 @@
#include "core/inspector/v8/V8DebuggerAgent.h"
#include "core/inspector/v8/V8DebuggerImpl.h"
#include "core/inspector/v8/V8DebuggerListener.h"
+#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
#include "wtf/HashMap.h"
#include "wtf/HashSet.h"
@@ -51,7 +52,7 @@ public:
~V8DebuggerAgentImpl() override;
DECLARE_TRACE();
- void setInspectorState(InspectorState* state) override { m_state = state; }
+ void setInspectorState(InspectorState*) override;
void setFrontend(InspectorFrontend::Debugger* frontend) override { m_frontend = frontend; }
void clearFrontend() override;
void restore() override;
@@ -194,7 +195,7 @@ private:
V8DebuggerImpl* m_debugger;
int m_contextGroupId;
bool m_enabled;
- InspectorState* m_state;
+ RawPtrWillBeWeakPersistent<InspectorState> m_state;
InspectorFrontend::Debugger* m_frontend;
v8::Isolate* m_isolate;
RefPtr<ScriptState> m_pausedScriptState;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698