Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Side by Side Diff: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h

Issue 1446973002: Oilpan: tidy up InspectorState weak references. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 17 matching lines...) Expand all
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef V8RuntimeAgentImpl_h 31 #ifndef V8RuntimeAgentImpl_h
32 #define V8RuntimeAgentImpl_h 32 #define V8RuntimeAgentImpl_h
33 33
34 #include "core/CoreExport.h" 34 #include "core/CoreExport.h"
35 #include "core/InspectorFrontend.h" 35 #include "core/InspectorFrontend.h"
36 #include "core/inspector/InspectorBaseAgent.h" 36 #include "core/inspector/InspectorBaseAgent.h"
37 #include "core/inspector/v8/V8RuntimeAgent.h" 37 #include "core/inspector/v8/V8RuntimeAgent.h"
38 #include "platform/heap/Handle.h"
38 #include "wtf/Forward.h" 39 #include "wtf/Forward.h"
39 #include "wtf/Noncopyable.h" 40 #include "wtf/Noncopyable.h"
40 41
41 namespace blink { 42 namespace blink {
42 43
43 class InjectedScript; 44 class InjectedScript;
44 class InjectedScriptManager; 45 class InjectedScriptManager;
45 class JSONArray; 46 class JSONArray;
46 class ScriptState; 47 class ScriptState;
47 class V8DebuggerImpl; 48 class V8DebuggerImpl;
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 void getProperties(ErrorString*, const String& objectId, const bool* ownProp erties, const bool* accessorPropertiesOnly, const bool* generatePreview, RefPtr< TypeBuilder::Array<TypeBuilder::Runtime::PropertyDescriptor>>& result, RefPtr<Ty peBuilder::Array<TypeBuilder::Runtime::InternalPropertyDescriptor>>& internalPro perties, RefPtr<TypeBuilder::Debugger::ExceptionDetails>&) final; 88 void getProperties(ErrorString*, const String& objectId, const bool* ownProp erties, const bool* accessorPropertiesOnly, const bool* generatePreview, RefPtr< TypeBuilder::Array<TypeBuilder::Runtime::PropertyDescriptor>>& result, RefPtr<Ty peBuilder::Array<TypeBuilder::Runtime::InternalPropertyDescriptor>>& internalPro perties, RefPtr<TypeBuilder::Debugger::ExceptionDetails>&) final;
88 void releaseObjectGroup(ErrorString*, const String& objectGroup) final; 89 void releaseObjectGroup(ErrorString*, const String& objectGroup) final;
89 void run(ErrorString*) override; 90 void run(ErrorString*) override;
90 void isRunRequired(ErrorString*, bool* out_result) override; 91 void isRunRequired(ErrorString*, bool* out_result) override;
91 void setCustomObjectFormatterEnabled(ErrorString*, bool) final; 92 void setCustomObjectFormatterEnabled(ErrorString*, bool) final;
92 93
93 private: 94 private:
94 InjectedScriptManager* injectedScriptManager() { return m_injectedScriptMana ger; } 95 InjectedScriptManager* injectedScriptManager() { return m_injectedScriptMana ger; }
95 void addExecutionContextToFrontend(int executionContextId, const String& typ e, const String& origin, const String& humanReadableName, const String& frameId) override; 96 void addExecutionContextToFrontend(int executionContextId, const String& typ e, const String& origin, const String& humanReadableName, const String& frameId) override;
96 97
97 InspectorState* m_state; 98 RawPtrWillBeWeakPersistent<InspectorState> m_state;
98 InspectorFrontend::Runtime* m_frontend; 99 InspectorFrontend::Runtime* m_frontend;
99 RawPtrWillBeWeakPersistent<InjectedScriptManager> m_injectedScriptManager; 100 RawPtrWillBeWeakPersistent<InjectedScriptManager> m_injectedScriptManager;
100 V8DebuggerImpl* m_debugger; 101 V8DebuggerImpl* m_debugger;
101 }; 102 };
102 103
103 } // namespace blink 104 } // namespace blink
104 105
105 #endif // V8RuntimeAgentImpl_h 106 #endif // V8RuntimeAgentImpl_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698