Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 144003006: Turn NVPR on by default (but off in tools). (Closed)

Created:
6 years, 11 months ago by bsalomon
Modified:
6 years, 11 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : op = -> clone function #

Patch Set 4 : remove NVPR expectations GM [will regenerate when GM has an explicit nvpr config] #

Patch Set 5 : cleanup and fixes #

Patch Set 6 : fix #

Total comments: 6

Patch Set 7 : fix nits #

Patch Set 8 : make GL context current before deleting GrContext in GrContextFactory #

Patch Set 9 : expect to fail nvpr context type test when nvpr is not supported #

Patch Set 10 : expect to fail nvpr context type test when nvpr is not supported #

Patch Set 11 : fix vs 2010 x86 debugger builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -16468 lines) Patch
D expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release-NVPR/expected-results.json View 1 2 3 1 chunk +0 lines, -16425 lines 0 comments Download
M gyp/common_variables.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/gpu.gyp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M include/gpu/GrContextFactory.h View 1 2 3 4 5 6 7 6 chunks +28 lines, -3 lines 0 comments Download
M include/gpu/gl/GrGLConfig.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M include/gpu/gl/GrGLExtensions.h View 1 2 3 4 2 chunks +12 lines, -2 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +7 lines, -2 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 4 5 3 chunks +10 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLExtensions.cpp View 1 2 3 4 5 6 2 chunks +41 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 2 3 4 4 chunks +74 lines, -3 lines 0 comments Download
M src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/win/SkNativeGLContext_win.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests/GLInterfaceValidation.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bsalomon
This will temporarily make it impossible to run NVPR in tools. I will enable that ...
6 years, 11 months ago (2014-01-22 18:05:18 UTC) #1
robertphillips
lgtm modulo what's up with that try bot. 3 nits too. https://codereview.chromium.org/144003006/diff/130001/include/gpu/GrContextFactory.h File include/gpu/GrContextFactory.h (right): ...
6 years, 11 months ago (2014-01-22 20:12:05 UTC) #2
bsalomon
I believe I've fixed the try bot. If it passes I'll land. https://codereview.chromium.org/144003006/diff/130001/include/gpu/GrContextFactory.h File include/gpu/GrContextFactory.h ...
6 years, 11 months ago (2014-01-23 16:16:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/144003006/340001
6 years, 11 months ago (2014-01-24 14:11:25 UTC) #4
commit-bot: I haz the power
Change committed as 13164
6 years, 11 months ago (2014-01-24 14:38:20 UTC) #5
bsalomon
A revert of this CL has been created in https://codereview.chromium.org/146583004/ by bsalomon@google.com. The reason for ...
6 years, 11 months ago (2014-01-24 15:16:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/144003006/480001
6 years, 11 months ago (2014-01-24 20:36:11 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 20:49:59 UTC) #8
Message was sent while issue was closed.
Change committed as 13176

Powered by Google App Engine
This is Rietveld 408576698