Issue 14354003: HArgument instructions currently require a frame. In Lithium we can ensure a frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14354003: HArgument instructions currently require a frame. In Lithium we can ensure a frame (Closed)

Created:
7 years, 8 months ago by mvstanton

Modified:
7 years, 8 months ago

Reviewers:
Hannes Payer (out of office), danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

HArgument instructions currently require a frame. In Lithium we can ensure a frame is created for these instructions via a compile info flag. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14339

Patch Set 1 #

Created: 7 years, 8 months ago

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -3 lines)
M	src/arm/lithium-arm.cc	View	2 chunks	+3 lines, -0 lines	0 comments
M	src/arm/lithium-codegen-arm.h	View	1 chunk	+2 lines, -1 line	0 comments
M	src/compiler.h	View	2 chunks	+10 lines, -0 lines	0 comments
M	src/ia32/lithium-codegen-ia32.h	View	1 chunk	+2 lines, -1 line	0 comments
M	src/ia32/lithium-ia32.cc	View	2 chunks	+3 lines, -0 lines	0 comments
M	src/x64/lithium-codegen-x64.h	View	1 chunk	+2 lines, -1 line	0 comments
M	src/x64/lithium-x64.cc	View	2 chunks	+3 lines, -0 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Danno, here is the fix you suggested for the HArguments/frame issues. It works well for ...

7 years, 8 months ago (2013-04-18 12:21:11 UTC) #1

mvstanton

7 years, 8 months ago (2013-04-18 15:44:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14339 (presubmit successful).

Expand Messages | Collapse Messages