src/x64/lithium-codegen-x64.h - Issue 14354003: HArgument instructions currently require a frame. In Lithium we can ensure a frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.h

Issue 14354003: HArgument instructions currently require a frame. In Lithium we can ensure a frame (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-codegen-x64.h

diff --git a/src/x64/lithium-codegen-x64.h b/src/x64/lithium-codegen-x64.h

index e8576068307cc4d484d1dcd6a5b5dc9b9cc1f148..e211b48c195b80030f7f66abed93e9b5861f50e6 100644

--- a/src/x64/lithium-codegen-x64.h

+++ b/src/x64/lithium-codegen-x64.h

@@ -82,7 +82,8 @@ class LCodeGen BASE_EMBEDDED {

bool NeedsEagerFrame() const {

return GetStackSlotCount() > 0 ||

info()->is_non_deferred_calling() ||

- !info()->IsStub();

+ !info()->IsStub() ||

+ info()->requires_frame();

}

bool NeedsDeferredFrame() const {

return !NeedsEagerFrame() && info()->is_deferred_calling();

« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »