Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 14354003: HArgument instructions currently require a frame. In Lithium we can ensure a frame (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 975 matching lines...) Expand 10 before | Expand all | Expand 10 after
986 986
987 987
988 LInstruction* LChunkBuilder::DoCompareMap(HCompareMap* instr) { 988 LInstruction* LChunkBuilder::DoCompareMap(HCompareMap* instr) {
989 ASSERT(instr->value()->representation().IsTagged()); 989 ASSERT(instr->value()->representation().IsTagged());
990 LOperand* value = UseRegisterAtStart(instr->value()); 990 LOperand* value = UseRegisterAtStart(instr->value());
991 return new(zone()) LCmpMapAndBranch(value); 991 return new(zone()) LCmpMapAndBranch(value);
992 } 992 }
993 993
994 994
995 LInstruction* LChunkBuilder::DoArgumentsLength(HArgumentsLength* length) { 995 LInstruction* LChunkBuilder::DoArgumentsLength(HArgumentsLength* length) {
996 info()->MarkAsRequiresFrame();
996 return DefineAsRegister(new(zone()) LArgumentsLength(Use(length->value()))); 997 return DefineAsRegister(new(zone()) LArgumentsLength(Use(length->value())));
997 } 998 }
998 999
999 1000
1000 LInstruction* LChunkBuilder::DoArgumentsElements(HArgumentsElements* elems) { 1001 LInstruction* LChunkBuilder::DoArgumentsElements(HArgumentsElements* elems) {
1002 info()->MarkAsRequiresFrame();
1001 return DefineAsRegister(new(zone()) LArgumentsElements); 1003 return DefineAsRegister(new(zone()) LArgumentsElements);
1002 } 1004 }
1003 1005
1004 1006
1005 LInstruction* LChunkBuilder::DoInstanceOf(HInstanceOf* instr) { 1007 LInstruction* LChunkBuilder::DoInstanceOf(HInstanceOf* instr) {
1006 LOperand* left = UseFixed(instr->left(), rax); 1008 LOperand* left = UseFixed(instr->left(), rax);
1007 LOperand* right = UseFixed(instr->right(), rdx); 1009 LOperand* right = UseFixed(instr->right(), rdx);
1008 LInstanceOf* result = new(zone()) LInstanceOf(left, right); 1010 LInstanceOf* result = new(zone()) LInstanceOf(left, right);
1009 return MarkAsCall(DefineFixed(result, rax), instr); 1011 return MarkAsCall(DefineFixed(result, rax), instr);
1010 } 1012 }
(...skipping 1356 matching lines...) Expand 10 before | Expand all | Expand 10 after
2367 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) { 2369 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) {
2368 // There are no real uses of the arguments object. 2370 // There are no real uses of the arguments object.
2369 // arguments.length and element access are supported directly on 2371 // arguments.length and element access are supported directly on
2370 // stack arguments, and any real arguments object use causes a bailout. 2372 // stack arguments, and any real arguments object use causes a bailout.
2371 // So this value is never used. 2373 // So this value is never used.
2372 return NULL; 2374 return NULL;
2373 } 2375 }
2374 2376
2375 2377
2376 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) { 2378 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) {
2379 info()->MarkAsRequiresFrame();
2377 LOperand* args = UseRegister(instr->arguments()); 2380 LOperand* args = UseRegister(instr->arguments());
2378 LOperand* length = UseTempRegister(instr->length()); 2381 LOperand* length = UseTempRegister(instr->length());
2379 LOperand* index = Use(instr->index()); 2382 LOperand* index = Use(instr->index());
2380 return DefineAsRegister(new(zone()) LAccessArgumentsAt(args, length, index)); 2383 return DefineAsRegister(new(zone()) LAccessArgumentsAt(args, length, index));
2381 } 2384 }
2382 2385
2383 2386
2384 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) { 2387 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) {
2385 LOperand* object = UseFixed(instr->value(), rax); 2388 LOperand* object = UseFixed(instr->value(), rax);
2386 LToFastProperties* result = new(zone()) LToFastProperties(object); 2389 LToFastProperties* result = new(zone()) LToFastProperties(object);
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
2520 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2523 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2521 LOperand* object = UseRegister(instr->object()); 2524 LOperand* object = UseRegister(instr->object());
2522 LOperand* index = UseTempRegister(instr->index()); 2525 LOperand* index = UseTempRegister(instr->index());
2523 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2526 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2524 } 2527 }
2525 2528
2526 2529
2527 } } // namespace v8::internal 2530 } } // namespace v8::internal
2528 2531
2529 #endif // V8_TARGET_ARCH_X64 2532 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698