Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 14354003: HArgument instructions currently require a frame. In Lithium we can ensure a frame (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.h ('k') | src/x64/lithium-codegen-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1034 matching lines...) Expand 10 before | Expand all | Expand 10 after
1045 1045
1046 1046
1047 LInstruction* LChunkBuilder::DoCompareMap(HCompareMap* instr) { 1047 LInstruction* LChunkBuilder::DoCompareMap(HCompareMap* instr) {
1048 ASSERT(instr->value()->representation().IsTagged()); 1048 ASSERT(instr->value()->representation().IsTagged());
1049 LOperand* value = UseRegisterAtStart(instr->value()); 1049 LOperand* value = UseRegisterAtStart(instr->value());
1050 return new(zone()) LCmpMapAndBranch(value); 1050 return new(zone()) LCmpMapAndBranch(value);
1051 } 1051 }
1052 1052
1053 1053
1054 LInstruction* LChunkBuilder::DoArgumentsLength(HArgumentsLength* length) { 1054 LInstruction* LChunkBuilder::DoArgumentsLength(HArgumentsLength* length) {
1055 info()->MarkAsRequiresFrame();
1055 return DefineAsRegister(new(zone()) LArgumentsLength(Use(length->value()))); 1056 return DefineAsRegister(new(zone()) LArgumentsLength(Use(length->value())));
1056 } 1057 }
1057 1058
1058 1059
1059 LInstruction* LChunkBuilder::DoArgumentsElements(HArgumentsElements* elems) { 1060 LInstruction* LChunkBuilder::DoArgumentsElements(HArgumentsElements* elems) {
1061 info()->MarkAsRequiresFrame();
1060 return DefineAsRegister(new(zone()) LArgumentsElements); 1062 return DefineAsRegister(new(zone()) LArgumentsElements);
1061 } 1063 }
1062 1064
1063 1065
1064 LInstruction* LChunkBuilder::DoInstanceOf(HInstanceOf* instr) { 1066 LInstruction* LChunkBuilder::DoInstanceOf(HInstanceOf* instr) {
1065 LOperand* left = UseFixed(instr->left(), InstanceofStub::left()); 1067 LOperand* left = UseFixed(instr->left(), InstanceofStub::left());
1066 LOperand* right = UseFixed(instr->right(), InstanceofStub::right()); 1068 LOperand* right = UseFixed(instr->right(), InstanceofStub::right());
1067 LOperand* context = UseFixed(instr->context(), esi); 1069 LOperand* context = UseFixed(instr->context(), esi);
1068 LInstanceOf* result = new(zone()) LInstanceOf(context, left, right); 1070 LInstanceOf* result = new(zone()) LInstanceOf(context, left, right);
1069 return MarkAsCall(DefineFixed(result, eax), instr); 1071 return MarkAsCall(DefineFixed(result, eax), instr);
(...skipping 1494 matching lines...) Expand 10 before | Expand all | Expand 10 after
2564 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) { 2566 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) {
2565 // There are no real uses of the arguments object. 2567 // There are no real uses of the arguments object.
2566 // arguments.length and element access are supported directly on 2568 // arguments.length and element access are supported directly on
2567 // stack arguments, and any real arguments object use causes a bailout. 2569 // stack arguments, and any real arguments object use causes a bailout.
2568 // So this value is never used. 2570 // So this value is never used.
2569 return NULL; 2571 return NULL;
2570 } 2572 }
2571 2573
2572 2574
2573 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) { 2575 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) {
2576 info()->MarkAsRequiresFrame();
2574 LOperand* args = UseRegister(instr->arguments()); 2577 LOperand* args = UseRegister(instr->arguments());
2575 LOperand* length = UseTempRegister(instr->length()); 2578 LOperand* length = UseTempRegister(instr->length());
2576 LOperand* index = Use(instr->index()); 2579 LOperand* index = Use(instr->index());
2577 return DefineAsRegister(new(zone()) LAccessArgumentsAt(args, length, index)); 2580 return DefineAsRegister(new(zone()) LAccessArgumentsAt(args, length, index));
2578 } 2581 }
2579 2582
2580 2583
2581 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) { 2584 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) {
2582 LOperand* object = UseFixed(instr->value(), eax); 2585 LOperand* object = UseFixed(instr->value(), eax);
2583 LToFastProperties* result = new(zone()) LToFastProperties(object); 2586 LToFastProperties* result = new(zone()) LToFastProperties(object);
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
2724 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2727 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2725 LOperand* object = UseRegister(instr->object()); 2728 LOperand* object = UseRegister(instr->object());
2726 LOperand* index = UseTempRegister(instr->index()); 2729 LOperand* index = UseTempRegister(instr->index());
2727 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2730 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2728 } 2731 }
2729 2732
2730 2733
2731 } } // namespace v8::internal 2734 } } // namespace v8::internal
2732 2735
2733 #endif // V8_TARGET_ARCH_IA32 2736 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.h ('k') | src/x64/lithium-codegen-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698