Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 14354003: HArgument instructions currently require a frame. In Lithium we can ensure a frame (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 967 matching lines...) Expand 10 before | Expand all | Expand 10 after
978 978
979 LInstruction* LChunkBuilder::DoCompareMap(HCompareMap* instr) { 979 LInstruction* LChunkBuilder::DoCompareMap(HCompareMap* instr) {
980 ASSERT(instr->value()->representation().IsTagged()); 980 ASSERT(instr->value()->representation().IsTagged());
981 LOperand* value = UseRegisterAtStart(instr->value()); 981 LOperand* value = UseRegisterAtStart(instr->value());
982 LOperand* temp = TempRegister(); 982 LOperand* temp = TempRegister();
983 return new(zone()) LCmpMapAndBranch(value, temp); 983 return new(zone()) LCmpMapAndBranch(value, temp);
984 } 984 }
985 985
986 986
987 LInstruction* LChunkBuilder::DoArgumentsLength(HArgumentsLength* instr) { 987 LInstruction* LChunkBuilder::DoArgumentsLength(HArgumentsLength* instr) {
988 info()->MarkAsRequiresFrame();
988 LOperand* value = UseRegister(instr->value()); 989 LOperand* value = UseRegister(instr->value());
989 return DefineAsRegister(new(zone()) LArgumentsLength(value)); 990 return DefineAsRegister(new(zone()) LArgumentsLength(value));
990 } 991 }
991 992
992 993
993 LInstruction* LChunkBuilder::DoArgumentsElements(HArgumentsElements* elems) { 994 LInstruction* LChunkBuilder::DoArgumentsElements(HArgumentsElements* elems) {
995 info()->MarkAsRequiresFrame();
994 return DefineAsRegister(new(zone()) LArgumentsElements); 996 return DefineAsRegister(new(zone()) LArgumentsElements);
995 } 997 }
996 998
997 999
998 LInstruction* LChunkBuilder::DoInstanceOf(HInstanceOf* instr) { 1000 LInstruction* LChunkBuilder::DoInstanceOf(HInstanceOf* instr) {
999 LInstanceOf* result = 1001 LInstanceOf* result =
1000 new(zone()) LInstanceOf(UseFixed(instr->left(), r0), 1002 new(zone()) LInstanceOf(UseFixed(instr->left(), r0),
1001 UseFixed(instr->right(), r1)); 1003 UseFixed(instr->right(), r1));
1002 return MarkAsCall(DefineFixed(result, r0), instr); 1004 return MarkAsCall(DefineFixed(result, r0), instr);
1003 } 1005 }
(...skipping 1441 matching lines...) Expand 10 before | Expand all | Expand 10 after
2445 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) { 2447 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) {
2446 // There are no real uses of the arguments object. 2448 // There are no real uses of the arguments object.
2447 // arguments.length and element access are supported directly on 2449 // arguments.length and element access are supported directly on
2448 // stack arguments, and any real arguments object use causes a bailout. 2450 // stack arguments, and any real arguments object use causes a bailout.
2449 // So this value is never used. 2451 // So this value is never used.
2450 return NULL; 2452 return NULL;
2451 } 2453 }
2452 2454
2453 2455
2454 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) { 2456 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) {
2457 info()->MarkAsRequiresFrame();
2455 LOperand* args = UseRegister(instr->arguments()); 2458 LOperand* args = UseRegister(instr->arguments());
2456 LOperand* length = UseTempRegister(instr->length()); 2459 LOperand* length = UseTempRegister(instr->length());
2457 LOperand* index = UseRegister(instr->index()); 2460 LOperand* index = UseRegister(instr->index());
2458 return DefineAsRegister(new(zone()) LAccessArgumentsAt(args, length, index)); 2461 return DefineAsRegister(new(zone()) LAccessArgumentsAt(args, length, index));
2459 } 2462 }
2460 2463
2461 2464
2462 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) { 2465 LInstruction* LChunkBuilder::DoToFastProperties(HToFastProperties* instr) {
2463 LOperand* object = UseFixed(instr->value(), r0); 2466 LOperand* object = UseFixed(instr->value(), r0);
2464 LToFastProperties* result = new(zone()) LToFastProperties(object); 2467 LToFastProperties* result = new(zone()) LToFastProperties(object);
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
2594 2597
2595 2598
2596 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2599 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2597 LOperand* object = UseRegister(instr->object()); 2600 LOperand* object = UseRegister(instr->object());
2598 LOperand* index = UseRegister(instr->index()); 2601 LOperand* index = UseRegister(instr->index());
2599 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2602 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2600 } 2603 }
2601 2604
2602 2605
2603 } } // namespace v8::internal 2606 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698