Use a bezier timing function for the overview mode animation

Add two new gfx::Tween::Types and use one of them for the timing function for the overview mode animation

BUG=334428
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248967

[pkotwicz, 2014-01-24 19:49:45]

Ian, can you please take a look?

[pkotwicz, 2014-01-28 02:24:13]

Ping?

[Ian Vollick, 2014-01-29 01:28:14]

On 2014/01/28 02:24:13, pkotwicz wrote:
> Ping?

Lgtm

[pkotwicz, 2014-02-04 04:22:29]

sky@ for ui/gfx OWNERS
flackr@ for ash/wm/overview OWNERS

[flackr, 2014-02-04 14:33:04]

ash/wm/overview LGTM

[sky, 2014-02-04 15:14:39]

https://codereview.chromium.org/143413020/diff/60001/ui/gfx/geometry/cubic_be...
File ui/gfx/geometry/cubic_bezier.h (right):

https://codereview.chromium.org/143413020/diff/60001/ui/gfx/geometry/cubic_be...
ui/gfx/geometry/cubic_bezier.h:1: // Copyright 2012 The Chromium Authors. All
rights reserved.
2014

https://codereview.chromium.org/143413020/diff/60001/ui/gfx/geometry/cubic_be...
ui/gfx/geometry/cubic_bezier.h:5: #ifndef UI_GFX_GEOMETRY_CUBIC_BEZIER_H_
nit: play with the --similarity so this isn't seen as a copy.

https://codereview.chromium.org/143413020/diff/60001/ui/gfx/geometry/cubic_be...
ui/gfx/geometry/cubic_bezier.h:16: virtual ~CubicBezier();
Why the virtual?

[pkotwicz, 2014-02-04 19:46:51]

Scott, can you please take another look?

[sky, 2014-02-04 22:43:06]

LGTM

[pkotwicz, 2014-02-05 05:35:31]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-05 05:42:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/143413020/460001

[commit-bot: I haz the power, 2014-02-05 05:42:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-05 05:42:55]

Failed to apply patch for ui/gfx/geometry/cubic_bezier_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: ui/gfx/geometry/cubic_bezier_unittest.cc
  |diff --git a/ui/gfx/geometry/cubic_bezier_unittest.cc
b/ui/gfx/geometry/cubic_bezier_unittest.cc
  |index
4be225fd6b929f78c1db378b963cd65f3a6e6822..4fd60e87825ae9f0ce68514f5e26e2518e84b3eb
100644
  |--- a/ui/gfx/geometry/cubic_bezier_unittest.cc
  |+++ b/ui/gfx/geometry/cubic_bezier_unittest.cc
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       ui/gfx/geometry/cubic_bezier_unittest.cc
Index: ui/gfx/geometry/cubic_bezier_unittest.cc
diff --git a/ui/gfx/geometry/cubic_bezier_unittest.cc
b/ui/gfx/geometry/cubic_bezier_unittest.cc
index
4be225fd6b929f78c1db378b963cd65f3a6e6822..4fd60e87825ae9f0ce68514f5e26e2518e84b3eb
100644
--- a/ui/gfx/geometry/cubic_bezier_unittest.cc
+++ b/ui/gfx/geometry/cubic_bezier_unittest.cc
@@ -1,141 +1,140 @@
-// Copyright 2011 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "cc/animation/timing_function.h"
+#include "ui/gfx/geometry/cubic_bezier.h"
 
+#include "base/memory/scoped_ptr.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
-namespace cc {
+namespace gfx {
 namespace {
 
-TEST(TimingFunctionTest, CubicBezierTimingFunction) {
-  scoped_ptr<CubicBezierTimingFunction> function =
-      CubicBezierTimingFunction::Create(0.25, 0.0, 0.75, 1.0);
+TEST(CubicBezierTest, Basic) {
+  CubicBezier function(0.25, 0.0, 0.75, 1.0);
 
   double epsilon = 0.00015;
 
-  EXPECT_NEAR(function->GetValue(0), 0, epsilon);
-  EXPECT_NEAR(function->GetValue(0.05), 0.01136, epsilon);
-  EXPECT_NEAR(function->GetValue(0.1), 0.03978, epsilon);
-  EXPECT_NEAR(function->GetValue(0.15), 0.079780, epsilon);
-  EXPECT_NEAR(function->GetValue(0.2), 0.12803, epsilon);
-  EXPECT_NEAR(function->GetValue(0.25), 0.18235, epsilon);
-  EXPECT_NEAR(function->GetValue(0.3), 0.24115, epsilon);
-  EXPECT_NEAR(function->GetValue(0.35), 0.30323, epsilon);
-  EXPECT_NEAR(function->GetValue(0.4), 0.36761, epsilon);
-  EXPECT_NEAR(function->GetValue(0.45), 0.43345, epsilon);
-  EXPECT_NEAR(function->GetValue(0.5), 0.5, epsilon);
-  EXPECT_NEAR(function->GetValue(0.6), 0.63238, epsilon);
-  EXPECT_NEAR(function->GetValue(0.65), 0.69676, epsilon);
-  EXPECT_NEAR(function->GetValue(0.7), 0.75884, epsilon);
-  EXPECT_NEAR(function->GetValue(0.75), 0.81764, epsilon);
-  EXPECT_NEAR(function->GetValue(0.8), 0.87196, epsilon);
-  EXPECT_NEAR(function->GetValue(0.85), 0.92021, epsilon);
-  EXPECT_NEAR(function->GetValue(0.9), 0.96021, epsilon);
-  EXPECT_NEAR(function->GetValue(0.95), 0.98863, epsilon);
-  EXPECT_NEAR(function->GetValue(1), 1, epsilon);
+  EXPECT_NEAR(function.Solve(0), 0, epsilon);
+  EXPECT_NEAR(function.Solve(0.05), 0.01136, epsilon);
+  EXPECT_NEAR(function.Solve(0.1), 0.03978, epsilon);
+  EXPECT_NEAR(function.Solve(0.15), 0.079780, epsilon);
+  EXPECT_NEAR(function.Solve(0.2), 0.12803, epsilon);
+  EXPECT_NEAR(function.Solve(0.25), 0.18235, epsilon);
+  EXPECT_NEAR(function.Solve(0.3), 0.24115, epsilon);
+  EXPECT_NEAR(function.Solve(0.35), 0.30323, epsilon);
+  EXPECT_NEAR(function.Solve(0.4), 0.36761, epsilon);
+  EXPECT_NEAR(function.Solve(0.45), 0.43345, epsilon);
+  EXPECT_NEAR(function.Solve(0.5), 0.5, epsilon);
+  EXPECT_NEAR(function.Solve(0.6), 0.63238, epsilon);
+  EXPECT_NEAR(function.Solve(0.65), 0.69676, epsilon);
+  EXPECT_NEAR(function.Solve(0.7), 0.75884, epsilon);
+  EXPECT_NEAR(function.Solve(0.75), 0.81764, epsilon);
+  EXPECT_NEAR(function.Solve(0.8), 0.87196, epsilon);
+  EXPECT_NEAR(function.Solve(0.85), 0.92021, epsilon);
+  EXPECT_NEAR(function.Solve(0.9), 0.96021, epsilon);
+  EXPECT_NEAR(function.Solve(0.95), 0.98863, epsilon);
+  EXPECT_NEAR(function.Solve(1), 1, epsilon);
 }
 
-// Tests that the bezier timing function works with knots with y not in (0, 1).
-TEST(TimingFunctionTest, CubicBezierTimingFunctionUnclampedYValues) {
-  scoped_ptr<CubicBezierTimingFunction> function =
-      CubicBezierTimingFunction::Create(0.5, -1.0, 0.5, 2.0);
+// Tests that solving the bezier works with knots with y not in (0, 1).
+TEST(CubicBezierTest, UnclampedYValues) {
+  CubicBezier function(0.5, -1.0, 0.5, 2.0);
 
   double epsilon = 0.00015;
 
-  EXPECT_NEAR(function->GetValue(0.0), 0.0, epsilon);
-  EXPECT_NEAR(function->GetValue(0.05), -0.08954, epsilon);
-  EXPECT_NEAR(function->GetValue(0.1), -0.15613, epsilon);
-  EXPECT_NEAR(function->GetValue(0.15), -0.19641, epsilon);
-  EXPECT_NEAR(function->GetValue(0.2), -0.20651, epsilon);
-  EXPECT_NEAR(function->GetValue(0.25), -0.18232, epsilon);
-  EXPECT_NEAR(function->GetValue(0.3), -0.11992, epsilon);
-  EXPECT_NEAR(function->GetValue(0.35), -0.01672, epsilon);
-  EXPECT_NEAR(function->GetValue(0.4), 0.12660, epsilon);
-  EXPECT_NEAR(function->GetValue(0.45), 0.30349, epsilon);
-  EXPECT_NEAR(function->GetValue(0.5), 0.50000, epsilon);
-  EXPECT_NEAR(function->GetValue(0.55), 0.69651, epsilon);
-  EXPECT_NEAR(function->GetValue(0.6), 0.87340, epsilon);
-  EXPECT_NEAR(function->GetValue(0.65), 1.01672, epsilon);
-  EXPECT_NEAR(function->GetValue(0.7), 1.11992, epsilon);
-  EXPECT_NEAR(function->GetValue(0.75), 1.18232, epsilon);
-  EXPECT_NEAR(function->GetValue(0.8), 1.20651, epsilon);
-  EXPECT_NEAR(function->GetValue(0.85), 1.19641, epsilon);
-  EXPECT_NEAR(function->GetValue(0.9), 1.15613, epsilon);
-  EXPECT_NEAR(function->GetValue(0.95), 1.08954, epsilon);
-  EXPECT_NEAR(function->GetValue(1.0), 1.0, epsilon);
+  EXPECT_NEAR(function.Solve(0.0), 0.0, epsilon);
+  EXPECT_NEAR(function.Solve(0.05), -0.08954, epsilon);
+  EXPECT_NEAR(function.Solve(0.1), -0.15613, epsilon);
+  EXPECT_NEAR(function.Solve(0.15), -0.19641, epsilon);
+  EXPECT_NEAR(function.Solve(0.2), -0.20651, epsilon);
+  EXPECT_NEAR(function.Solve(0.25), -0.18232, epsilon);
+  EXPECT_NEAR(function.Solve(0.3), -0.11992, epsilon);
+  EXPECT_NEAR(function.Solve(0.35), -0.01672, epsilon);
+  EXPECT_NEAR(function.Solve(0.4), 0.12660, epsilon);
+  EXPECT_NEAR(function.Solve(0.45), 0.30349, epsilon);
+  EXPECT_NEAR(function.Solve(0.5), 0.50000, epsilon);
+  EXPECT_NEAR(function.Solve(0.55), 0.69651, epsilon);
+  EXPECT_NEAR(function.Solve(0.6), 0.87340, epsilon);
+  EXPECT_NEAR(function.Solve(0.65), 1.01672, epsilon);
+  EXPECT_NEAR(function.Solve(0.7), 1.11992, epsilon);
+  EXPECT_NEAR(function.Solve(0.75), 1.18232, epsilon);
+  EXPECT_NEAR(function.Solve(0.8), 1.20651, epsilon);
+  EXPECT_NEAR(function.Solve(0.85), 1.19641, epsilon);
+  EXPECT_NEAR(function.Solve(0.9), 1.15613, epsilon);
+  EXPECT_NEAR(function.Solve(0.95), 1.08954, epsilon);
+  EXPECT_NEAR(function.Solve(1.0), 1.0, epsilon);
 }
 
-TEST(TimingFunctionTest, CubicBezierTimingFunctionRange) {
+TEST(CubicBezierTest, Range) {
   double epsilon = 0.00015;
-  float min, max;
+  double min, max;
 
   // Derivative is a constant.
-  scoped_ptr<CubicBezierTimingFunction> function =
-      CubicBezierTimingFunction::Create(0.25, (1.0 / 3.0), 0.75, (2.0 / 3.0));
+  scoped_ptr<CubicBezier> function(
+      new CubicBezier(0.25, (1.0 / 3.0), 0.75, (2.0 / 3.0)));
   function->Range(&min, &max);
-  EXPECT_EQ(0.f, min);
-  EXPECT_EQ(1.f, max);
+  EXPECT_EQ(0, min);
+  EXPECT_EQ(1, max);
 
   // Derivative is linear.
-  function = CubicBezierTimingFunction::Create(0.25, -0.5, 0.75, (-1.0 / 6.0));
+  function.reset(new CubicBezier(0.25, -0.5, 0.75, (-1.0 / 6.0)));
   function->Range(&min, &max);
   EXPECT_NEAR(min, -0.225, epsilon);
-  EXPECT_EQ(1.f, max);
+  EXPECT_EQ(1, max);
 
   // Derivative has no real roots.
-  function = CubicBezierTimingFunction::Create(0.25, 0.25, 0.75, 0.5);
+  function.reset(new CubicBezier(0.25, 0.25, 0.75, 0.5));
   function->Range(&min, &max);
-  EXPECT_EQ(0.f, min);
-  EXPECT_EQ(1.f, max);
+  EXPECT_EQ(0, min);
+  EXPECT_EQ(1, max);
 
   // Derivative has exactly one real root.
-  function = CubicBezierTimingFunction::Create(0.0, 1.0, 1.0, 0.0);
+  function.reset(new CubicBezier(0.0, 1.0, 1.0, 0.0));
   function->Range(&min, &max);
-  EXPECT_EQ(0.f, min);
-  EXPECT_EQ(1.f, max);
+  EXPECT_EQ(0, min);
+  EXPECT_EQ(1, max);
 
   // Derivative has one root < 0 and one root > 1.
-  function = CubicBezierTimingFunction::Create(0.25, 0.1, 0.75, 0.9);
+  function.reset(new CubicBezier(0.25, 0.1, 0.75, 0.9));
   function->Range(&min, &max);
-  EXPECT_EQ(0.f, min);
-  EXPECT_EQ(1.f, max);
+  EXPECT_EQ(0, min);
+  EXPECT_EQ(1, max);
 
   // Derivative has two roots in [0,1].
-  function = CubicBezierTimingFunction::Create(0.25, 2.5, 0.75, 0.5);
+  function.reset(new CubicBezier(0.25, 2.5, 0.75, 0.5));
   function->Range(&min, &max);
-  EXPECT_EQ(0.f, min);
+  EXPECT_EQ(0, min);
   EXPECT_NEAR(max, 1.28818, epsilon);
-  function = CubicBezierTimingFunction::Create(0.25, 0.5, 0.75, -1.5);
+  function.reset(new CubicBezier(0.25, 0.5, 0.75, -1.5));
   function->Range(&min, &max);
   EXPECT_NEAR(min, -0.28818, epsilon);
-  EXPECT_EQ(1.f, max);
+  EXPECT_EQ(1, max);
 
   // Derivative has one root < 0 and one root in [0,1].
-  function = CubicBezierTimingFunction::Create(0.25, 0.1, 0.75, 1.5);
+  function.reset(new CubicBezier(0.25, 0.1, 0.75, 1.5));
   function->Range(&min, &max);
-  EXPECT_EQ(0.f, min);
+  EXPECT_EQ(0, min);
   EXPECT_NEAR(max, 1.10755, epsilon);
 
   // Derivative has one root in [0,1] and one root > 1.
-  function = CubicBezierTimingFunction::Create(0.25, -0.5, 0.75, 0.9);
+  function.reset(new CubicBezier(0.25, -0.5, 0.75, 0.9));
   function->Range(&min, &max);
   EXPECT_NEAR(min, -0.10755, epsilon);
-  EXPECT_EQ(1.f, max);
+  EXPECT_EQ(1, max);
 
   // Derivative has two roots < 0.
-  function = CubicBe…
(message too large)

[pkotwicz, 2014-02-05 06:50:15]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-05 06:57:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/143413020/80002

[commit-bot: I haz the power, 2014-02-05 11:34:07]

Change committed as 248967