Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1431323003: Remove obsolete OS handling in GN. (Closed)

Created:
5 years, 1 month ago by brettw
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete OS handling in GN. There was a a bunch of built-in special-casing of the current_os variable which has been gradually removed over time as we have needed extra flexibility and reduced special casing. The only use of this was for libs ending in .framework on Mac. I think it's OK to run the special-casing on all OS's, since in pracice libraries on Windows and Linux can't end in ".framework". A bunch of setup and maintenance of these variables is removed. Committed: https://crrev.com/d4f9637d51829c0d779e7ce07b945e8b7813397d Cr-Commit-Position: refs/heads/master@{#359170}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -52 lines) Patch
M tools/gn/function_get_target_outputs_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/ninja_action_target_writer_unittest.cc View 6 chunks +0 lines, -6 lines 0 comments Download
M tools/gn/ninja_binary_target_writer.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M tools/gn/ninja_binary_target_writer_unittest.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M tools/gn/ninja_copy_target_writer_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M tools/gn/settings.h View 1 3 chunks +0 lines, -16 lines 0 comments Download
M tools/gn/settings.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/gn/variables.cc View 1 2 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
brettw
5 years, 1 month ago (2015-11-11 00:49:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431323003/20001
5 years, 1 month ago (2015-11-11 00:51:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-11 01:11:48 UTC) #6
scottmg
lgtm Maybe in the comment/doc you could add something about it being for Mac, even ...
5 years, 1 month ago (2015-11-11 04:06:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431323003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431323003/40001
5 years, 1 month ago (2015-11-11 21:36:22 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-11 22:12:04 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:00:59 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d4f9637d51829c0d779e7ce07b945e8b7813397d
Cr-Commit-Position: refs/heads/master@{#359170}

Powered by Google App Engine
This is Rietveld 408576698