Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/ninja_action_target_writer_unittest.cc

Issue 1431323003: Remove obsolete OS handling in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_get_target_outputs_unittest.cc ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_action_target_writer_unittest.cc
diff --git a/tools/gn/ninja_action_target_writer_unittest.cc b/tools/gn/ninja_action_target_writer_unittest.cc
index a7dd21b4a8f6550a7e9bfdefa5fa92b7bd62af37..38a175b9fad7d7e1bc485f76e9e6cf1957cd45c6 100644
--- a/tools/gn/ninja_action_target_writer_unittest.cc
+++ b/tools/gn/ninja_action_target_writer_unittest.cc
@@ -54,7 +54,6 @@ TEST(NinjaActionTargetWriter, ActionNoSources) {
target.SetToolchain(setup.toolchain());
ASSERT_TRUE(target.OnResolved(&err));
- setup.settings()->set_target_os(Settings::LINUX);
setup.build_settings()->set_python_path(base::FilePath(FILE_PATH_LITERAL(
"/usr/bin/python")));
@@ -96,7 +95,6 @@ TEST(NinjaActionTargetWriter, ActionNoSourcesConsole) {
target.SetToolchain(setup.toolchain());
ASSERT_TRUE(target.OnResolved(&err));
- setup.settings()->set_target_os(Settings::LINUX);
setup.build_settings()->set_python_path(base::FilePath(FILE_PATH_LITERAL(
"/usr/bin/python")));
@@ -140,7 +138,6 @@ TEST(NinjaActionTargetWriter, ActionWithSources) {
target.SetToolchain(setup.toolchain());
ASSERT_TRUE(target.OnResolved(&err));
- setup.settings()->set_target_os(Settings::LINUX);
setup.build_settings()->set_python_path(base::FilePath(FILE_PATH_LITERAL(
"/usr/bin/python")));
@@ -206,7 +203,6 @@ TEST(NinjaActionTargetWriter, ForEach) {
target.SetToolchain(setup.toolchain());
ASSERT_TRUE(target.OnResolved(&err));
- setup.settings()->set_target_os(Settings::LINUX);
setup.build_settings()->set_python_path(base::FilePath(FILE_PATH_LITERAL(
"/usr/bin/python")));
@@ -275,7 +271,6 @@ TEST(NinjaActionTargetWriter, ForEachWithDepfile) {
target.inputs().push_back(SourceFile("//foo/included.txt"));
- setup.settings()->set_target_os(Settings::LINUX);
setup.build_settings()->set_python_path(base::FilePath(FILE_PATH_LITERAL(
"/usr/bin/python")));
@@ -335,7 +330,6 @@ TEST(NinjaActionTargetWriter, ForEachWithResponseFile) {
target.action_values().outputs() = SubstitutionList::MakeForTest(
"//out/Debug/{{source_name_part}}.out");
- setup.settings()->set_target_os(Settings::LINUX);
setup.build_settings()->set_python_path(base::FilePath(FILE_PATH_LITERAL(
"/usr/bin/python")));
« no previous file with comments | « tools/gn/function_get_target_outputs_unittest.cc ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698