Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: tools/gn/settings.h

Issue 1431323003: Remove obsolete OS handling in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_copy_target_writer_unittest.cc ('k') | tools/gn/settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/settings.h
diff --git a/tools/gn/settings.h b/tools/gn/settings.h
index e66a13f6a35736bfd2383766e8dc5259391318b1..e07ee2e039c48319ec7c437201c167e6666dc03d 100644
--- a/tools/gn/settings.h
+++ b/tools/gn/settings.h
@@ -26,13 +26,6 @@
// the file with the toolchain declaration in it.
class Settings {
public:
- enum TargetOS {
- UNKNOWN,
- LINUX,
- MAC,
- WIN
- };
-
// Constructs a toolchain settings.
//
// The output_subdir_name is the name we should use for the subdirectory in
@@ -60,13 +53,6 @@ class Settings {
return toolchain_label_ == default_toolchain_label_;
}
- bool IsMac() const { return target_os_ == MAC; }
- bool IsLinux() const { return target_os_ == LINUX; }
- bool IsWin() const { return target_os_ == WIN; }
-
- TargetOS target_os() const { return target_os_; }
- void set_target_os(TargetOS t) { target_os_ = t; }
-
const OutputFile& toolchain_output_subdir() const {
return toolchain_output_subdir_;
}
@@ -106,8 +92,6 @@ class Settings {
Label toolchain_label_;
Label default_toolchain_label_;
- TargetOS target_os_;
-
mutable ImportManager import_manager_;
// The subdirectory inside the build output for this toolchain. For the
« no previous file with comments | « tools/gn/ninja_copy_target_writer_unittest.cc ('k') | tools/gn/settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698