tools/gn/ninja_copy_target_writer_unittest.cc - Issue 1431323003: Remove obsolete OS handling in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_copy_target_writer_unittest.cc

Issue 1431323003: Remove obsolete OS handling in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_copy_target_writer_unittest.cc

diff --git a/tools/gn/ninja_copy_target_writer_unittest.cc b/tools/gn/ninja_copy_target_writer_unittest.cc

index 12496bf0f82ba0c7faba18242664eaa7bbcd821f..e6ec2225dff2838527bdd65e5881a7dafb8805d4 100644

--- a/tools/gn/ninja_copy_target_writer_unittest.cc

+++ b/tools/gn/ninja_copy_target_writer_unittest.cc

@@ -15,7 +15,6 @@ TEST(NinjaCopyTargetWriter, Run) {

TestWithScope setup;

Err err;

- setup.settings()->set_target_os(Settings::LINUX);

setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));

Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));

target.set_output_type(Target::COPY_FILES);

@@ -47,7 +46,6 @@ TEST(NinjaCopyTargetWriter, ToolchainDeps) {

TestWithScope setup;

Err err;

- setup.settings()->set_target_os(Settings::LINUX);

setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));

Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));

target.set_output_type(Target::COPY_FILES);

@@ -76,7 +74,6 @@ TEST(NinjaCopyTargetWriter, OrderOnlyDeps) {

TestWithScope setup;

Err err;

- setup.settings()->set_target_os(Settings::LINUX);

setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));

Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));

« no previous file with comments | « tools/gn/ninja_binary_target_writer_unittest.cc ('k') | tools/gn/settings.h » ('j') | no next file with comments »