Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1430643002: Remove min texture size support (Closed)

Created:
5 years, 1 month ago by bsalomon
Modified:
5 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Delete even more! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -116 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +0 lines, -3 lines 0 comments Download
M include/gpu/GrContextOptions.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/core/SkImageCacherator.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/GrCaps.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +4 lines, -13 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.h View 1 3 chunks +2 lines, -14 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 2 chunks +4 lines, -39 lines 0 comments Download
M src/gpu/GrTextureProvider.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 3 chunks +0 lines, -13 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 5 chunks +7 lines, -9 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Issue 1420963008 Patch 1
Issue 1420963008 Patch 20001
Issue 1420963008 Patch 40001

Messages

Total messages: 12 (4 generated)
bsalomon
5 years, 1 month ago (2015-10-28 13:55:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430643002/1
5 years, 1 month ago (2015-10-28 13:55:54 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-10-28 13:55:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430643002/40001
5 years, 1 month ago (2015-10-28 14:58:04 UTC) #8
robertphillips
lgtm. Just to be sure, this does still work on the PowerVR chips, right?
5 years, 1 month ago (2015-10-28 15:36:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://skia.googlesource.com/skia/+/100b8f8c079510a6b7572f9ed8058c1d4a2bfeba
5 years, 1 month ago (2015-10-28 15:37:48 UTC) #10
robertphillips
Okay - I read the bug. We're adopting a scorched earth policy for those gpus.
5 years, 1 month ago (2015-10-28 15:38:01 UTC) #11
bsalomon
5 years, 1 month ago (2015-10-28 15:38:25 UTC) #12
Message was sent while issue was closed. 
On 2015/10/28 15:36:17, robertphillips wrote:
> lgtm. Just to be sure, this does still work on the PowerVR chips, right?

Does not, has not for a long time. I discovered that Ganesh is blacklisted for
all PowerVR 54x in Chrome for both raster and c2d. Since this wasn't working
anyway and is a major blocker for reworking drawBitmap/Image[Rect] I decided to
kill it. If we want to add back support I'd prefer to do it after that work is
complete.

Powered by Google App Engine
This is Rietveld 408576698