Pull texture-backed bitmap resampler out of GrTextureParamsAdjuster code into its own class.

Pull texture-backed bitmap resampler out of GrTextureParamsAdjuster code into its own class.

Committed: https://skia.googlesource.com/skia/+/89fe56bb98de55c7bd2b547c875b74a98bd5a1ca

[bsalomon, 2015-10-29 15:28:59]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2015-10-29 15:28:59]

I may wind up bringing these back together at some point, or perhaps more likely
will add some common public virtuals to the Producer, but this makes it easier
to move forward on refactoring the drawBmp/drawImg code.

[reed1, 2015-10-29 15:39:22]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-10-29 15:39:22]

lgtm

[bsalomon, 2015-10-29 16:33:40]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 16:33:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420963008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420963008/40001

[commit-bot: I haz the power, 2015-10-29 16:36:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 16:36:04]

Dry run: Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)

[bsalomon, 2015-10-29 16:52:56]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 16:53:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420963008/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420963008/60001

[commit-bot: I haz the power, 2015-10-29 16:54:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 16:54:12]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[robertphillips, 2015-10-29 16:57:54]

lgtm

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/GrTextureParams...
File src/gpu/GrTextureParamsAdjuster.cpp (right):

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.cpp:99: 
rect -> dstRect ?
move it to right before drawNonAARectToRect call ?

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/GrTextureParams...
File src/gpu/GrTextureParamsAdjuster.h (right):

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.h:63: *  If a stretched version of the texture
is generated, it may be cached (assuming that
onMakeParamsKey ?

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.h:108: GrTextureMaker(int width, int height) :
fWidth(width), fHeight(height) {}
override ?

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/SkGr.cpp#newcod...
src/gpu/SkGr.cpp:280: 
rm the stray \n ?

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/SkGr.cpp#newcod...
src/gpu/SkGr.cpp:350: // The texture subset must represent the whole bitmap.
Texture-backed bitmaps don't support
teture is -> texture are ?

https://codereview.chromium.org/1420963008/diff/60001/src/gpu/GrTextureParams...
File src/gpu/GrTextureParamsAdjuster.h (right):

https://codereview.chromium.org/1420963008/diff/60001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.h:64: *  onMakeParamsKey() returns true). In
that case, the maker is notified in case it
Should "maker" be "producer" here ?

[robertphillips, 2015-10-29 17:07:05]

https://codereview.chromium.org/1420963008/diff/60001/src/gpu/GrTextureParams...
File src/gpu/GrTextureParamsAdjuster.h (right):

https://codereview.chromium.org/1420963008/diff/60001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.h:7: 
Should this file be renamed ?
Should this macro be renamed too ?

[bsalomon, 2015-10-29 17:14:41]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-10-29 17:14:42]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1420963008/#ps80001
(title: "Address comments and remove call to deprecated MakeFromIRect")

[commit-bot: I haz the power, 2015-10-29 17:14:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420963008/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420963008/80001

[commit-bot: I haz the power, 2015-10-29 17:15:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 17:15:46]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[bsalomon, 2015-10-29 17:36:22]

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/GrTextureParams...
File src/gpu/GrTextureParamsAdjuster.cpp (right):

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.cpp:99: 
On 2015/10/29 16:57:54, robertphillips wrote:
> rect -> dstRect ?
> move it to right before drawNonAARectToRect call ?

Done.

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/GrTextureParams...
File src/gpu/GrTextureParamsAdjuster.h (right):

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.h:63: *  If a stretched version of the texture
is generated, it may be cached (assuming that
On 2015/10/29 16:57:54, robertphillips wrote:
> onMakeParamsKey ?

Done.

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.h:108: GrTextureMaker(int width, int height) :
fWidth(width), fHeight(height) {}
On 2015/10/29 16:57:54, robertphillips wrote:
> override ?

rm'ed the function

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/SkGr.cpp#newcod...
src/gpu/SkGr.cpp:280: 
On 2015/10/29 16:57:54, robertphillips wrote:
> rm the stray \n ?

Done.

https://codereview.chromium.org/1420963008/diff/40001/src/gpu/SkGr.cpp#newcod...
src/gpu/SkGr.cpp:350: // The texture subset must represent the whole bitmap.
Texture-backed bitmaps don't support
On 2015/10/29 16:57:54, robertphillips wrote:
> teture is -> texture are ?

Done.

https://codereview.chromium.org/1420963008/diff/60001/src/gpu/GrTextureParams...
File src/gpu/GrTextureParamsAdjuster.h (right):

https://codereview.chromium.org/1420963008/diff/60001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.h:7: 
On 2015/10/29 17:07:05, robertphillips wrote:
> Should this file be renamed ?
> Should this macro be renamed too ?

Probably... will do in a later CL, this may evolve a bit more.

https://codereview.chromium.org/1420963008/diff/60001/src/gpu/GrTextureParams...
src/gpu/GrTextureParamsAdjuster.h:64: *  onMakeParamsKey() returns true). In
that case, the maker is notified in case it
On 2015/10/29 16:57:54, robertphillips wrote:
> Should "maker" be "producer" here ?

Done.

[bsalomon, 2015-10-29 17:38:04]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-10-29 17:38:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/1420963008/#ps100001
(title: "fix unused var warning")

[commit-bot: I haz the power, 2015-10-29 17:38:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420963008/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420963008/100001

[commit-bot: I haz the power, 2015-10-29 17:49:31]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/89fe56bb98de55c7bd2b547c875b74a98bd5a1ca