Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1429113003: [DevTools] Narrow down DevToolsNetworkTransaction surface. (Closed)

Created:
5 years, 1 month ago by dgozman
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Narrow down DevToolsNetworkTransaction surface. BUG=none Committed: https://crrev.com/bb9bd2891d2fd5024bfc47287fbf646c808c73de Cr-Commit-Position: refs/heads/master@{#357933}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -28 lines) Patch
M chrome/browser/devtools/devtools_network_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_network_controller.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/devtools/devtools_network_transaction.h View 1 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/devtools/devtools_network_transaction.cc View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dgozman
Take a look please.
5 years, 1 month ago (2015-11-03 02:04:57 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1429113003/diff/1/chrome/browser/devtools/devtools_network_transaction.h File chrome/browser/devtools/devtools_network_transaction.h (right): https://codereview.chromium.org/1429113003/diff/1/chrome/browser/devtools/devtools_network_transaction.h#newcode106 chrome/browser/devtools/devtools_network_transaction.h:106: // "X-DevTools-Emulate-Network-Conditions-Client-Id"DevTools header. space missing
5 years, 1 month ago (2015-11-03 22:53:54 UTC) #3
dgozman
https://codereview.chromium.org/1429113003/diff/1/chrome/browser/devtools/devtools_network_transaction.h File chrome/browser/devtools/devtools_network_transaction.h (right): https://codereview.chromium.org/1429113003/diff/1/chrome/browser/devtools/devtools_network_transaction.h#newcode106 chrome/browser/devtools/devtools_network_transaction.h:106: // "X-DevTools-Emulate-Network-Conditions-Client-Id"DevTools header. On 2015/11/03 22:53:54, pfeldman wrote: > ...
5 years, 1 month ago (2015-11-04 22:54:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429113003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429113003/20001
5 years, 1 month ago (2015-11-04 22:55:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-04 23:44:07 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 23:45:24 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bb9bd2891d2fd5024bfc47287fbf646c808c73de
Cr-Commit-Position: refs/heads/master@{#357933}

Powered by Google App Engine
This is Rietveld 408576698