Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: chrome/browser/devtools/devtools_network_controller.cc

Issue 1429113003: [DevTools] Narrow down DevToolsNetworkTransaction surface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_network_controller.cc
diff --git a/chrome/browser/devtools/devtools_network_controller.cc b/chrome/browser/devtools/devtools_network_controller.cc
index b5fa8ad80f1fba3d6b018b50a25846d1acff9e8e..03ba6e2730fa55571ed31582371317d3d313adbf 100644
--- a/chrome/browser/devtools/devtools_network_controller.cc
+++ b/chrome/browser/devtools/devtools_network_controller.cc
@@ -6,7 +6,6 @@
#include "chrome/browser/devtools/devtools_network_conditions.h"
#include "chrome/browser/devtools/devtools_network_interceptor.h"
-#include "chrome/browser/devtools/devtools_network_transaction.h"
#include "net/http/http_request_info.h"
DevToolsNetworkController::DevToolsNetworkController()
@@ -19,17 +18,9 @@ DevToolsNetworkController::~DevToolsNetworkController() {
base::WeakPtr<DevToolsNetworkInterceptor>
DevToolsNetworkController::GetInterceptor(
- DevToolsNetworkTransaction* transaction) {
+ const std::string& client_id) {
DCHECK(thread_checker_.CalledOnValidThread());
- DCHECK(transaction->HasStarted());
-
- if (!interceptors_.size())
- return default_interceptor_->GetWeakPtr();
-
- transaction->ProcessRequest();
-
- const std::string& client_id = transaction->client_id();
- if (client_id.empty())
+ if (!interceptors_.size() || client_id.empty())
return default_interceptor_->GetWeakPtr();
DevToolsNetworkInterceptor* interceptor = interceptors_.get(client_id);
« no previous file with comments | « chrome/browser/devtools/devtools_network_controller.h ('k') | chrome/browser/devtools/devtools_network_transaction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698