Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: chrome/browser/devtools/devtools_network_controller.cc

Issue 1429113003: [DevTools] Narrow down DevToolsNetworkTransaction surface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/devtools_network_controller.h" 5 #include "chrome/browser/devtools/devtools_network_controller.h"
6 6
7 #include "chrome/browser/devtools/devtools_network_conditions.h" 7 #include "chrome/browser/devtools/devtools_network_conditions.h"
8 #include "chrome/browser/devtools/devtools_network_interceptor.h" 8 #include "chrome/browser/devtools/devtools_network_interceptor.h"
9 #include "chrome/browser/devtools/devtools_network_transaction.h"
10 #include "net/http/http_request_info.h" 9 #include "net/http/http_request_info.h"
11 10
12 DevToolsNetworkController::DevToolsNetworkController() 11 DevToolsNetworkController::DevToolsNetworkController()
13 : default_interceptor_(new DevToolsNetworkInterceptor()), 12 : default_interceptor_(new DevToolsNetworkInterceptor()),
14 appcache_interceptor_(new DevToolsNetworkInterceptor()) {} 13 appcache_interceptor_(new DevToolsNetworkInterceptor()) {}
15 14
16 DevToolsNetworkController::~DevToolsNetworkController() { 15 DevToolsNetworkController::~DevToolsNetworkController() {
17 DCHECK(thread_checker_.CalledOnValidThread()); 16 DCHECK(thread_checker_.CalledOnValidThread());
18 } 17 }
19 18
20 base::WeakPtr<DevToolsNetworkInterceptor> 19 base::WeakPtr<DevToolsNetworkInterceptor>
21 DevToolsNetworkController::GetInterceptor( 20 DevToolsNetworkController::GetInterceptor(
22 DevToolsNetworkTransaction* transaction) { 21 const std::string& client_id) {
23 DCHECK(thread_checker_.CalledOnValidThread()); 22 DCHECK(thread_checker_.CalledOnValidThread());
24 DCHECK(transaction->HasStarted()); 23 if (!interceptors_.size() || client_id.empty())
25
26 if (!interceptors_.size())
27 return default_interceptor_->GetWeakPtr();
28
29 transaction->ProcessRequest();
30
31 const std::string& client_id = transaction->client_id();
32 if (client_id.empty())
33 return default_interceptor_->GetWeakPtr(); 24 return default_interceptor_->GetWeakPtr();
34 25
35 DevToolsNetworkInterceptor* interceptor = interceptors_.get(client_id); 26 DevToolsNetworkInterceptor* interceptor = interceptors_.get(client_id);
36 if (!interceptor) 27 if (!interceptor)
37 return default_interceptor_->GetWeakPtr(); 28 return default_interceptor_->GetWeakPtr();
38 29
39 return interceptor->GetWeakPtr(); 30 return interceptor->GetWeakPtr();
40 } 31 }
41 32
42 void DevToolsNetworkController::SetNetworkState( 33 void DevToolsNetworkController::SetNetworkState(
(...skipping 30 matching lines...) Expand all
73 } 64 }
74 } 65 }
75 66
76 bool is_appcache_offline = appcache_interceptor_->conditions()->offline(); 67 bool is_appcache_offline = appcache_interceptor_->conditions()->offline();
77 if (is_appcache_offline != has_offline_interceptors) { 68 if (is_appcache_offline != has_offline_interceptors) {
78 scoped_ptr<DevToolsNetworkConditions> appcache_conditions( 69 scoped_ptr<DevToolsNetworkConditions> appcache_conditions(
79 new DevToolsNetworkConditions(has_offline_interceptors)); 70 new DevToolsNetworkConditions(has_offline_interceptors));
80 appcache_interceptor_->UpdateConditions(appcache_conditions.Pass()); 71 appcache_interceptor_->UpdateConditions(appcache_conditions.Pass());
81 } 72 }
82 } 73 }
OLDNEW
« no previous file with comments | « chrome/browser/devtools/devtools_network_controller.h ('k') | chrome/browser/devtools/devtools_network_transaction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698