[DevTools] Narrow down DevToolsNetworkTransaction surface.

chrome/browser/devtools/devtools_network_transaction.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_NETWORK_TRANSACTION_H_
 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_NETWORK_TRANSACTION_H_
 
 #include <stdint.h>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 35 matching lines @@
       public DevToolsNetworkInterceptor::Throttable {
  public:
   static const char kDevToolsEmulateNetworkConditionsClientId[];
 
   DevToolsNetworkTransaction(
       DevToolsNetworkController* controller,
       scoped_ptr<net::HttpTransaction> network_transaction);
 
   ~DevToolsNetworkTransaction() override;
 
-  // Checks if request contains DevTools specific headers. Found values are
-  // remembered and corresponding keys are removed from headers.
-  void ProcessRequest();
-
-  const std::string& client_id() const {
-    return client_id_;
-  }
-
   // DevToolsNetworkInterceptor::Throttable implementation.
   bool HasStarted() override;
   bool HasFailed() override;
   void Fail() override;
   int64_t ThrottledByteCount() override;
   void Throttled(int64_t count) override;
   void ThrottleFinished() override;
   void GetSendEndTiming(base::TimeTicks* send_end) override;
 
   // HttpTransaction methods:
@@ skipping 29 matching lines @@
       const BeforeNetworkStartCallback& callback) override;
   void SetBeforeProxyHeadersSentCallback(
       const BeforeProxyHeadersSentCallback& callback) override;
   int ResumeNetworkStart() override;
   void GetConnectionAttempts(net::ConnectionAttempts* out) const override;
 
  protected:
   friend class test::DevToolsNetworkControllerHelper;
 
  private:
+  // Checks whether request contains
+  // "X-DevTools-Emulate-Network-Conditions-Client-Id"DevTools header.

[pfeldman, 2015/11/03 22:53:54]

space missing

[dgozman, 2015/11/04 22:54:06]

Done.

+  // If it does, header is removed from request, and it's value is returned.
+  void ProcessRequest(std::string* client_id);
+
   // Proxy callback handler. Runs saved callback.
   void OnCallback(int result);
 
   DevToolsNetworkController* controller_;
   base::WeakPtr<DevToolsNetworkInterceptor> interceptor_;
 
   // Modified request. Should be destructed after |network_transaction_|
   scoped_ptr<net::HttpRequestInfo> custom_request_;
 
   // Real network transaction.
   scoped_ptr<net::HttpTransaction> network_transaction_;
 
   const net::HttpRequestInfo* request_;
 
   // True if Fail was already invoked.
   bool failed_;
 
-  // Value of "X-DevTools-Emulate-Network-Conditions-Client-Id" request header.
+  // Value of  request header.
   std::string client_id_;
 
   enum CallbackType {
       NONE,
       READ,
       RESTART_IGNORING_LAST_ERROR,
       RESTART_WITH_AUTH,
       RESTART_WITH_CERTIFICATE,
       START
   };
 
   int SetupCallback(
       net::CompletionCallback callback,
       int result,
       CallbackType callback_type);
 
   void Throttle(int result);
 
   int throttled_result_;
   int64_t throttled_byte_count_;
   CallbackType callback_type_;
   net::CompletionCallback proxy_callback_;
   net::CompletionCallback callback_;
 
   DISALLOW_COPY_AND_ASSIGN(DevToolsNetworkTransaction);
 };
 
 #endif  // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_NETWORK_TRANSACTION_H_