Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1620)

Unified Diff: chrome/browser/devtools/devtools_network_transaction.h

Issue 1429113003: [DevTools] Narrow down DevToolsNetworkTransaction surface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_network_transaction.h
diff --git a/chrome/browser/devtools/devtools_network_transaction.h b/chrome/browser/devtools/devtools_network_transaction.h
index 08e3dc8456fcee0bc3e46e29b8bceb412700ae9d..df5ba2b76e5500eee5c3b2b90db6cf2bffe975a6 100644
--- a/chrome/browser/devtools/devtools_network_transaction.h
+++ b/chrome/browser/devtools/devtools_network_transaction.h
@@ -53,14 +53,6 @@ class DevToolsNetworkTransaction
~DevToolsNetworkTransaction() override;
- // Checks if request contains DevTools specific headers. Found values are
- // remembered and corresponding keys are removed from headers.
- void ProcessRequest();
-
- const std::string& client_id() const {
- return client_id_;
- }
-
// DevToolsNetworkInterceptor::Throttable implementation.
bool HasStarted() override;
bool HasFailed() override;
@@ -110,6 +102,11 @@ class DevToolsNetworkTransaction
friend class test::DevToolsNetworkControllerHelper;
private:
+ // Checks whether request contains
+ // "X-DevTools-Emulate-Network-Conditions-Client-Id" header.
+ // If it does, header is removed from request, and it's value is returned.
+ void ProcessRequest(std::string* client_id);
+
// Proxy callback handler. Runs saved callback.
void OnCallback(int result);
@@ -127,7 +124,7 @@ class DevToolsNetworkTransaction
// True if Fail was already invoked.
bool failed_;
- // Value of "X-DevTools-Emulate-Network-Conditions-Client-Id" request header.
+ // Value of request header.
std::string client_id_;
enum CallbackType {
« no previous file with comments | « chrome/browser/devtools/devtools_network_controller.cc ('k') | chrome/browser/devtools/devtools_network_transaction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698