[Interpreter] Add support for loading from / storing to outer context variables.

[Interpreter] Add support for loading from / storing to outer context variables.

Adds support for loading from and storing to outer context
variables. Also adds support for declaring functions on contexts and
locals. Finally, fixes a couple of issues with StaContextSlot where
we weren't emitting the write barrier and therefore would crash in the
GC.

Also added code so that --print-bytecode will output the
function name before the bytecodes, and replaces MachineType with StoreRepresentation in RawMachineAssembler::Store and updates tests.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/c0c214daa845dda0085563bfc44c8545fa94adf4
Cr-Commit-Position: refs/heads/master@{#31584}

[rmcilroy, 2015-10-26 13:03:10]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org, oth@chromium.org

[rmcilroy, 2015-10-26 13:03:10]

Orion / Michi, please take a look, thanks.

[Michael Starzinger, 2015-10-26 13:28:13]

Looking good, just one suggestion.

https://codereview.chromium.org/1425633002/diff/1/src/compiler/interpreter-as...
File src/compiler/interpreter-assembler.cc (right):

https://codereview.chromium.org/1425633002/diff/1/src/compiler/interpreter-as...
src/compiler/interpreter-assembler.cc:320: kFullWriteBarrier);
Hehe, yeah, this is a case of "scary default argument that everyone was worried
about finally hit us". :)

https://codereview.chromium.org/1425633002/diff/1/src/compiler/raw-machine-as...
File src/compiler/raw-machine-assembler.h (right):

https://codereview.chromium.org/1425633002/diff/1/src/compiler/raw-machine-as...
src/compiler/raw-machine-assembler.h:130: WriteBarrierKind write_barrier_kind =
kNoWriteBarrier) {
Joking aside: How much overhead would it be to not have a default argument here?
If it turns out to be, lets say, less than ten changes in the test suite, I
would vote for going for it. WDYT?

https://codereview.chromium.org/1425633002/diff/1/src/compiler/raw-machine-as...
src/compiler/raw-machine-assembler.h:134: WriteBarrierKind write_barrier_kind =
kNoWriteBarrier) {
Likewise.

[oth, 2015-10-26 14:13:27]

lgtm with minor comment.

https://codereview.chromium.org/1425633002/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/1425633002/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:66: OFStream os(stdout);
Left over debugging?

[rmcilroy, 2015-10-26 14:55:10]

Description was changed from

==========
[Interpreter] Add support for loading from / storing to outer context variables.

Adds support for loading from and storing to outer context
variables. Also adds support for declaring functions on contexts and
locals. Finally, fixes a couple of issues with lda/StaContextSlot where
we weren't emitting the write barrier and therefore would crash in the
GC.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Add support for loading from / storing to outer context variables.

Adds support for loading from and storing to outer context
variables. Also adds support for declaring functions on contexts and
locals. Finally, fixes a couple of issues with StaContextSlot where
we weren't emitting the write barrier and therefore would crash in the
GC.

Also added code so that --print-bytecode will output the 
function name before the bytecodes.  

BUG=v8:4280
LOG=N
==========

[rmcilroy, 2015-10-26 15:30:09]

Description was changed from

==========
[Interpreter] Add support for loading from / storing to outer context variables.

Adds support for loading from and storing to outer context
variables. Also adds support for declaring functions on contexts and
locals. Finally, fixes a couple of issues with StaContextSlot where
we weren't emitting the write barrier and therefore would crash in the
GC.

Also added code so that --print-bytecode will output the 
function name before the bytecodes.  

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Add support for loading from / storing to outer context variables.

Adds support for loading from and storing to outer context
variables. Also adds support for declaring functions on contexts and
locals. Finally, fixes a couple of issues with StaContextSlot where
we weren't emitting the write barrier and therefore would crash in the
GC.

Also added code so that --print-bytecode will output the 
function name before the bytecodes, and replaces MachineType with
StoreRepresentation in RawMachineAssembler::Store and updates tests.  

BUG=v8:4280
LOG=N
==========

[rmcilroy, 2015-10-26 15:37:51]

Comments addressed, PTAL.

https://codereview.chromium.org/1425633002/diff/1/src/compiler/interpreter-as...
File src/compiler/interpreter-assembler.cc (right):

https://codereview.chromium.org/1425633002/diff/1/src/compiler/interpreter-as...
src/compiler/interpreter-assembler.cc:320: kFullWriteBarrier);
On 2015/10/26 13:28:13, Michael Starzinger wrote:
> Hehe, yeah, this is a case of "scary default argument that everyone was
worried
> about finally hit us". :)

Acknowledged.

https://codereview.chromium.org/1425633002/diff/1/src/compiler/raw-machine-as...
File src/compiler/raw-machine-assembler.h (right):

https://codereview.chromium.org/1425633002/diff/1/src/compiler/raw-machine-as...
src/compiler/raw-machine-assembler.h:130: WriteBarrierKind write_barrier_kind =
kNoWriteBarrier) {
On 2015/10/26 13:28:13, Michael Starzinger wrote:
> Joking aside: How much overhead would it be to not have a default argument
here?
> If it turns out to be, lets say, less than ten changes in the test suite, I
> would vote for going for it. WDYT?

Good point - done by changing Store to take a StoreRepresentation instead of
separate MachineType/WriteBarrierKind arguments (although it was more like 130
change... ;)).

https://codereview.chromium.org/1425633002/diff/1/src/compiler/raw-machine-as...
src/compiler/raw-machine-assembler.h:134: WriteBarrierKind write_barrier_kind =
kNoWriteBarrier) {
On 2015/10/26 13:28:13, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/1425633002/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/1425633002/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:66: OFStream os(stdout);
On 2015/10/26 14:13:27, oth wrote:
> Left over debugging?

Nope - I think it is useful to have the function name when printing the
bytecodes so you can tie it to the JS. Added a comment in the description
mentioning this.

[rmcilroy, 2015-10-26 15:37:57]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-26 15:38:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1425633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1425633002/20001

[commit-bot: I haz the power, 2015-10-26 15:41:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-26 15:41:19]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_win_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/11067)

[Michael Starzinger, 2015-10-26 16:05:29]

LGTM.

[rmcilroy, 2015-10-26 16:24:15]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-26 16:24:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1425633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1425633002/40001

[commit-bot: I haz the power, 2015-10-26 16:39:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-26 16:39:57]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[rmcilroy, 2015-10-26 16:56:46]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-26 16:57:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1425633002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1425633002/60001

[rmcilroy, 2015-10-26 17:56:21]

The CQ bit was unchecked by rmcilroy@chromium.org

[rmcilroy, 2015-10-26 17:56:26]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-10-26 17:56:27]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1425633002/#ps60001
(title: "Fix interpreter-assembler-unittests")

[commit-bot: I haz the power, 2015-10-26 17:56:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1425633002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1425633002/60001

[commit-bot: I haz the power, 2015-10-26 18:11:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-26 18:11:42]

Patchset 4 (id:??) landed as
https://crrev.com/c0c214daa845dda0085563bfc44c8545fa94adf4
Cr-Commit-Position: refs/heads/master@{#31584}