test/unittests/compiler/interpreter-assembler-unittest.cc - Issue 1425633002: [Interpreter] Add support for loading from / storing to outer context variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/interpreter-assembler-unittest.cc

Issue 1425633002: [Interpreter] Add support for loading from / storing to outer context variables. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_conditional

Patch Set: Fix interpreter-assembler-unittests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc ('k') | test/unittests/compiler/mips/instruction-selector-mips-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/compiler/interpreter-assembler-unittest.cc

diff --git a/test/unittests/compiler/interpreter-assembler-unittest.cc b/test/unittests/compiler/interpreter-assembler-unittest.cc

index 33630330057b771d4cda1a0c6797a094c200d8d7..82ec7120e6887d4a93c32e78aae78868c9a841b7 100644

--- a/test/unittests/compiler/interpreter-assembler-unittest.cc

+++ b/test/unittests/compiler/interpreter-assembler-unittest.cc

@@ -497,9 +497,10 @@ TARGET_TEST_F(InterpreterAssemblerTest, StoreContextSlot) {

Matcher<Node*> offset =

IsIntPtrAdd(IsWordShl(slot_index, IsInt32Constant(kPointerSizeLog2)),

IsInt32Constant(Context::kHeaderSize - kHeapObjectTag));

- EXPECT_THAT(store_context_slot,

- m.IsStore(StoreRepresentation(kMachAnyTagged, kNoWriteBarrier),

- context, offset, value));

+ EXPECT_THAT(

+ store_context_slot,

+ m.IsStore(StoreRepresentation(kMachAnyTagged, kFullWriteBarrier),

+ context, offset, value));

}