Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417053004: [Interpreter] Add conditional expressions. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 1 month ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_prologue
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add conditional expressions. Adds support and tests for conditional (ternary) expressions. BUG=v8:4280 LOG=N Committed: https://crrev.com/2781ff6834c5369bc0270585d24f7e20341de7b3 Cr-Commit-Position: refs/heads/master@{#31575}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -1 line) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +20 lines, -1 line 2 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1412953007 Patch 40001

Dependent Patchsets:

Issue 1425633002 Patch 1
Issue 1425633002 Patch 20001
Issue 1425633002 Patch 40001
Issue 1425633002 Patch 60001

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417053004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417053004/20001
5 years, 2 months ago (2015-10-22 16:16:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417053004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417053004/40001
5 years, 2 months ago (2015-10-22 16:18:01 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417053004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417053004/60001
5 years, 2 months ago (2015-10-22 16:18:50 UTC) #9
rmcilroy
Orion, PTAL, thanks.
5 years, 2 months ago (2015-10-22 16:19:07 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-22 16:56:17 UTC) #13
oth
lgtm. Comment about the easy cases as we talked about. thanks! https://codereview.chromium.org/1417053004/diff/60001/src/interpreter/bytecode-generator.cc File src/interpreter/bytecode-generator.cc (right): ...
5 years, 1 month ago (2015-10-23 15:24:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417053004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417053004/60001
5 years, 1 month ago (2015-10-26 14:44:58 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 1 month ago (2015-10-26 15:31:09 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2781ff6834c5369bc0270585d24f7e20341de7b3 Cr-Commit-Position: refs/heads/master@{#31575}
5 years, 1 month ago (2015-10-26 15:31:40 UTC) #18
rmcilroy
5 years, 1 month ago (2015-10-27 12:03:35 UTC) #19
Message was sent while issue was closed. 
https://codereview.chromium.org/1417053004/diff/60001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/1417053004/diff/60001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:662: // obviously true/1/false/0.
On 2015/10/23 15:24:29, oth wrote:
> We should use ToBooleanIsFalse/True for the easy cases like
> VisitLogicalAndExpression.

Ack, I'll do this in a followup CL.

Powered by Google App Engine
This is Rietveld 408576698