Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1424983003: [turbofan] Cleanup RawMachineAssembler::Store interface. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Cleanup RawMachineAssembler::Store interface. R=bmeurer@chromium.org Committed: https://crrev.com/26fc85aae3dedece5619f55ac4812578c25e0416 Cr-Commit-Position: refs/heads/master@{#31646}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -148 lines) Patch
M src/compiler/interpreter-assembler.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 2 chunks +9 lines, -7 lines 0 comments Download
M test/cctest/compiler/c-signature.h View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 60 chunks +82 lines, -91 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Benedikt: PTAL. Ross: FYI. https://codereview.chromium.org/1424983003/diff/1/src/compiler/raw-machine-assembler.h File src/compiler/raw-machine-assembler.h (right): https://codereview.chromium.org/1424983003/diff/1/src/compiler/raw-machine-assembler.h#newcode504 src/compiler/raw-machine-assembler.h:504: return Store(rep, PointerConstant(address), node, kNoWriteBarrier); ...
5 years, 1 month ago (2015-10-28 14:14:47 UTC) #2
rmcilroy
LGTM from my point of view.
5 years, 1 month ago (2015-10-28 15:57:46 UTC) #3
Benedikt Meurer
LGTM
5 years, 1 month ago (2015-10-29 09:18:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424983003/20001
5 years, 1 month ago (2015-10-29 09:20:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-29 09:22:03 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 09:22:32 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26fc85aae3dedece5619f55ac4812578c25e0416
Cr-Commit-Position: refs/heads/master@{#31646}

Powered by Google App Engine
This is Rietveld 408576698