Issue 1421963005: Merge to XFA: The chromium_code whack-a-mole CLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1421963005: Merge to XFA: The chromium_code whack-a-mole CLs. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Nico

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: The chromium_code whack-a-mole CLs. BUG=pdfium:29 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1411583005 . Review URL: https://codereview.chromium.org/1431563002 . Review URL: https://codereview.chromium.org/1419943006 . Review URL: https://codereview.chromium.org/1415483003 . Review URL: https://codereview.chromium.org/1414073005 . Review URL: https://codereview.chromium.org/1415883010 . (cherry picked from commit 9f4def68601ec75b85b92077c521b9423b4f7f00) (cherry picked from commit 23e20f2d3ce5b416e1c7f7f1c2d68c90ddf2d4ad) (cherry picked from commit a6e2a4eca1be4daf14fae4e2427a6ca76269db43) (cherry picked from commit bfba4cb7f22fc19a5e71559f09f2cde19fbb6a79) (cherry picked from commit 81edc51ef8242205c5a1192bc33bf16d8c96120b) (cherry picked from commit 1630dffdc1d554d8f2319e83cdbd7b12f480362d) Committed: https://pdfium.googlesource.com/pdfium/+/476ac131cfd55842383f65418658a5f1103785b4

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -84 lines)			Patch
M	BUILD.gn	View	16 chunks	+29 lines, -74 lines	0 comments	Download
M	core/src/fxge/win32/fx_win32_device.cpp	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	core/src/fxge/win32/fx_win32_gdipext.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	core/src/fxge/win32/fx_win32_print.cpp	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	pdfium.gyp	View	2 chunks	+13 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 1 month ago (2015-11-06 04:07:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
476ac131cfd55842383f65418658a5f1103785b4 (presubmit successful).