Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1419943006: More chromium_code whack-a-mole. (Closed)

Created:
5 years, 1 month ago by Nico
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 3 chunks +1 line, -3 lines 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
linux looks happy in my roll cl, windows still isn't, so here's more stuff. I ...
5 years, 1 month ago (2015-10-30 19:27:39 UTC) #2
Lei Zhang
lgtm
5 years, 1 month ago (2015-10-30 20:03:35 UTC) #3
Nico
5 years, 1 month ago (2015-10-30 20:07:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6e2a4eca1be4daf14fae4e2427a6ca76269db43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698