Issue 1431563002: chromium_code tweaks for Windows and Linux/gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1431563002: chromium_code tweaks for Windows and Linux/gyp. (Closed)

Created:
5 years, 1 month ago by Nico

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

chromium_code tweaks for Windows and Linux/gyp. BUG=pdfium:29 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/23e20f2d3ce5b416e1c7f7f1c2d68c90ddf2d4ad

Patch Set 1 #

Total comments: 2

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	BUILD.gn	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	pdfium.gyp	View		1 chunk	+5 lines, -1 line	2 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

lgtm https://codereview.chromium.org/1431563002/diff/1/pdfium.gyp File pdfium.gyp (right): https://codereview.chromium.org/1431563002/diff/1/pdfium.gyp#newcode53 pdfium.gyp:53: # Make sure build/common.gypi doesn't re-add the flag ...

5 years, 1 month ago (2015-10-30 18:57:32 UTC) #3

Nico

Committed patchset #1 (id:1) manually as 23e20f2d3ce5b416e1c7f7f1c2d68c90ddf2d4ad (presubmit successful).

5 years, 1 month ago (2015-10-30 19:03:54 UTC) #4

Nico

5 years, 1 month ago (2015-10-30 19:09:31 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1431563002/diff/1/pdfium.gyp
File pdfium.gyp (right):

https://codereview.chromium.org/1431563002/diff/1/pdfium.gyp#newcode53
pdfium.gyp:53: # Make sure build/common.gypi doesn't re-add the flag on linux.
On 2015/10/30 18:57:32, Lei Zhang wrote:
> "Make sure Chromium's build/common.gypi"

(done, btw)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages