Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: pdfium.gyp

Issue 1421963005: Merge to XFA: The chromium_code whack-a-mole CLs. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/src/fxge/win32/fx_win32_print.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdfium.gyp
diff --git a/pdfium.gyp b/pdfium.gyp
index 14458714997ecd74085b71745ac3a0b4d473ecaf..cc3b2256231791c7f820284e3bad27f262ff3310 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -1,5 +1,7 @@
{
'variables': {
+ # TODO(thakis): Enable this, pdfium:29
+ #'chromium_code': 1,
'pdf_use_skia%': 0,
'pdf_enable_v8%': 1,
'pdf_enable_xfa%': 1,
@@ -48,8 +50,18 @@
}],
],
'msvs_disabled_warnings': [
- 4005, 4018, 4146, 4333, 4345, 4267
+ 4005, 4018, 4146, 4333, 4345, 4267,
+ # TODO(thestig): Fix all instances, remove this, pdfium:29
+ 4245, 4310, 4389, 4701, 4702, 4706, 4800,
],
+ 'variables': {
+ 'clang_warning_flags': [
+ # TODO(thestig): Fix all instances, remove this, pdfium:29
+ '-Wno-sign-compare',
+ ],
+ # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux.
+ 'cflags_cc!': [ '-Wsign-compare' ],
+ },
},
'targets': [
{
« no previous file with comments | « core/src/fxge/win32/fx_win32_print.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698