Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1415483003: chromium_code: Surrender in the gyp build for now. (Closed)

Created:
5 years, 1 month ago by Nico
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

chromium_code: Surrender in the gyp build for now. This is too hard debug with only roll try runs. I'll try again when I have access to linux and windows boxen (monday). BUG=pdfium:29 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bfba4cb7f22fc19a5e71559f09f2cde19fbb6a79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pdfium.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
:'-(
5 years, 1 month ago (2015-10-30 19:35:53 UTC) #2
Lei Zhang
boo, lgtm
5 years, 1 month ago (2015-10-30 20:00:36 UTC) #3
Nico
5 years, 1 month ago (2015-10-30 20:07:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bfba4cb7f22fc19a5e71559f09f2cde19fbb6a79 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698