Fix ClipMaskManager's SW-fallback logic

Fix ClipMaskManager's SW-fallback logic


'useSWOnlyPath' was not correctly toggling between stencil and color draws so there was a mismatch with the behavior in createAlphaClipMask (i.e., we were inadvertently rendering some of the elements in a clip using SW but using stenciling for others - precisely what 'useSWOnlyPath' was intended to prevent).

Committed: https://skia.googlesource.com/skia/+/5c3ea4cd3921e8904d4f201bcdedfd5b8a726542

[robertphillips, 2015-10-25 17:05:31]

Description was changed from

==========
Fix ClipMaskManager's SW-fallback logic
==========

to

==========
Fix ClipMaskManager's SW-fallback logic


'useSWOnlyPath' was not correctly toggling between stencil and color draws so
there was a mismatch with the behavior in createAlphaClipMask (i.e., we were
inadvertently
rendering some of the elements in a clip using SW but using stenciling for
others - precisely what 'useSWOnlyPath' was intended to prevent).
==========

[robertphillips, 2015-10-25 17:05:32]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2015-10-25 17:05:56]

Description was changed from

==========
Fix ClipMaskManager's SW-fallback logic


'useSWOnlyPath' was not correctly toggling between stencil and color draws so
there was a mismatch with the behavior in createAlphaClipMask (i.e., we were
inadvertently
rendering some of the elements in a clip using SW but using stenciling for
others - precisely what 'useSWOnlyPath' was intended to prevent).
==========

to

==========
Fix ClipMaskManager's SW-fallback logic


'useSWOnlyPath' was not correctly toggling between stencil and color draws so
there was a mismatch with the behavior in createAlphaClipMask (i.e., we were
inadvertently rendering some of the elements in a clip using SW but using
stenciling for others - precisely what 'useSWOnlyPath' was intended to prevent).
==========

[bsalomon, 2015-10-26 13:30:31]

lgtm, nice find

[robertphillips, 2015-10-26 13:42:01]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-26 13:42:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421533007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421533007/60001

[commit-bot: I haz the power, 2015-10-26 13:52:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-26 13:52:47]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-10-26 15:32:20]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-10-26 15:32:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1421533007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1421533007/60001

[commit-bot: I haz the power, 2015-10-26 15:33:12]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/5c3ea4cd3921e8904d4f201bcdedfd5b8a726542

[robertphillips, 2015-10-26 21:12:13]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1426443008/ by robertphillips@google.com.

The reason for reverting is: Logic may be incorrect.

[robertphillips, 2015-10-26 21:18:12]

Description was changed from

==========
Fix ClipMaskManager's SW-fallback logic


'useSWOnlyPath' was not correctly toggling between stencil and color draws so
there was a mismatch with the behavior in createAlphaClipMask (i.e., we were
inadvertently rendering some of the elements in a clip using SW but using
stenciling for others - precisely what 'useSWOnlyPath' was intended to prevent).

Committed:
https://skia.googlesource.com/skia/+/5c3ea4cd3921e8904d4f201bcdedfd5b8a726542
==========

to

==========
Fix ClipMaskManager's SW-fallback logic


'useSWOnlyPath' was not correctly toggling between stencil and color draws so
there was a mismatch with the behavior in createAlphaClipMask (i.e., we were
inadvertently rendering some of the elements in a clip using SW but using
stenciling for others - precisely what 'useSWOnlyPath' was intended to prevent).

Committed:
https://skia.googlesource.com/skia/+/5c3ea4cd3921e8904d4f201bcdedfd5b8a726542
==========

[robertphillips, 2015-10-27 14:00:05]

This CL has been split into:

https://codereview.chromium.org/1412883005 (Fix ClipMaskManager's SW-fallback
logic (take 2))
https://codereview.chromium.org/1422023003/ (Cosmetic portion of reverted "Fix
ClipMaskManager's SW-fallback logic" CL)
https://codereview.chromium.org/1424853002/ (Disable gpu-side clip mask merging
in the clip mask manager)