Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 1412883005: Fix ClipMaskManager's SW-fallback logic (take 2) (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix ClipMaskManager's SW-fallback logic (take 2) https://codereview.chromium.org/1421533007/ (Fix ClipMaskManager's SW-fallback logic) had a logic error in it. It did not take into account createAlphaClipMask's fallback to non-Stenciled drawing (in drawElement). This CL adds that logic and strips out the unnecessary changes (for clarity). Committed: https://skia.googlesource.com/skia/+/3f7357f1a0af60dddbd91fd457cb50a1771f0d13

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -24 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 1 4 chunks +66 lines, -24 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
robertphillips
5 years, 1 month ago (2015-10-27 12:26:24 UTC) #3
bsalomon
lgtm
5 years, 1 month ago (2015-10-27 13:22:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412883005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412883005/20001
5 years, 1 month ago (2015-10-27 13:55:16 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-27 14:06:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412883005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412883005/20001
5 years, 1 month ago (2015-10-27 14:16:59 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 14:17:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3f7357f1a0af60dddbd91fd457cb50a1771f0d13

Powered by Google App Engine
This is Rietveld 408576698