Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1419403002: Fix up the clip mask manager's creation of paths (w.r.t. volatility) (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@mdb-simplify-cmm
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix up the clip mask manager's creation of paths (w.r.t. volatility) I don't expect this to make any difference (perf-wise) but it seems more correct. This CL relies on https://codereview.chromium.org/1421533007/ (Fix ClipMaskManager's SW-fallback logic) Committed: https://skia.googlesource.com/skia/+/953fe3139fa60ce56abcfa45a3647d924e637083 Committed: https://skia.googlesource.com/skia/+/4d8762f8b055b9211a465bf67f136f496c5d182a

Patch Set 1 #

Patch Set 2 : Update to be independant of other CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/core/SkClipStack.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
robertphillips
5 years, 1 month ago (2015-10-26 12:13:23 UTC) #3
bsalomon
lgtm
5 years, 1 month ago (2015-10-26 16:11:31 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419403002/1
5 years, 1 month ago (2015-10-26 16:12:05 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-26 16:22:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419403002/1
5 years, 1 month ago (2015-10-26 16:27:16 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/953fe3139fa60ce56abcfa45a3647d924e637083
5 years, 1 month ago (2015-10-26 16:27:55 UTC) #12
robertphillips
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1415413007/ by robertphillips@google.com. ...
5 years, 1 month ago (2015-10-26 21:11:08 UTC) #13
robertphillips
relanding - I was mistaken it doesn't rely on https://codereview.chromium.org/1421533007/ (Fix ClipMaskManager's SW-fallback logic)
5 years, 1 month ago (2015-10-26 21:21:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419403002/20001
5 years, 1 month ago (2015-10-26 21:27:00 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 21:37:10 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4d8762f8b055b9211a465bf67f136f496c5d182a

Powered by Google App Engine
This is Rietveld 408576698