Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1420693006: Introduce a struct to store arguments of Element::focus(). (Closed)

Created:
5 years, 1 month ago by tkent
Modified:
5 years, 1 month ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, mlamouri+watch-blink_chromium.org, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce a struct to store arguments of Element::focus(). Also, converts the |restorePreviousSelection| argument to an enum class. This CL has no behavior changes, and improves code readability. BUG=526516 Committed: https://crrev.com/7e0e1b14e1033e03fa1dc772e2c44dfb45a7888b Cr-Commit-Position: refs/heads/master@{#358859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -50 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 2 chunks +21 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 3 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLegendElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLegendElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
kochi@, would you review this please? This is a preparation of crbug.com/526516, and I'll apply ...
5 years, 1 month ago (2015-11-10 14:29:59 UTC) #3
kochi
lgtm
5 years, 1 month ago (2015-11-10 17:21:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420693006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420693006/1
5 years, 1 month ago (2015-11-10 17:21:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 18:35:59 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 18:36:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e0e1b14e1033e03fa1dc772e2c44dfb45a7888b
Cr-Commit-Position: refs/heads/master@{#358859}

Powered by Google App Engine
This is Rietveld 408576698