third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp - Issue 1420693006: Introduce a struct to store arguments of Element::focus().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

Issue 1420693006: Introduce a struct to store arguments of Element::focus(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextAreaElement.h ('k') | third_party/WebKit/Source/core/html/forms/InputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

index 635a6a487ce432ca1cd2996ac698d0a7e04cb093..6c1aa8c557ee8ff6b646fd86f13520fb7d85f9af 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

@@ -241,13 +241,16 @@ bool HTMLTextAreaElement::shouldShowFocusRingOnMouseFocus() const

return true;

}

-void HTMLTextAreaElement::updateFocusAppearance(bool restorePreviousSelection)

+void HTMLTextAreaElement::updateFocusAppearance(SelectionBehaviorOnFocus selectionBehavior)

{

- if (!restorePreviousSelection)

+ switch (selectionBehavior) {

+ case SelectionBehaviorOnFocus::Reset:

setSelectionRange(0, 0, SelectionHasNoDirection, NotDispatchSelectEvent);

- else

+ break;

+ case SelectionBehaviorOnFocus::Restore:

restoreCachedSelection();

+ break;

+ }

if (document().frame())

document().frame()->selection().revealSelection();

}